-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [taro-webpack5-runner miniplugin]微信小程序tabbar list 中数据类型不匹配时编译时需报错提醒 #16225
Open
xujiujiu
wants to merge
2
commits into
NervJS:main
Choose a base branch
from
xujiujiu:feat-minitabbar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16225 +/- ##
=======================================
Coverage 58.50% 58.50%
=======================================
Files 466 466
Lines 27107 27107
Branches 5946 5954 +8
=======================================
Hits 15860 15860
- Misses 9769 9863 +94
+ Partials 1478 1384 -94
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Aug 3, 2024
This was referenced Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
编译成小程序时,若tabbar 的list中存在数据类型不匹配的情况,编译时需做报错提醒。当前情况只会报错:Cannot read properties of null (reading 'iconPath')
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: