Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dns_dhcp.rst #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cotosso
Copy link
Collaborator

@cotosso cotosso commented Feb 17, 2025

add a note : firewall IP outside dhcp range

add note firewall ip outside dhcp range
Copy link
Member

@filippocarletti filippocarletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that a note in the manual is not needed.
Let's use a UI validator.

@cotosso
Copy link
Collaborator Author

cotosso commented Feb 17, 2025

I think that a note in the manual is not needed. Let's use a UI validator.

A note costs nothing, explains how to properly configure the service, and can prevent some misconfigurations while waiting for a UI validator (about a month and a half wait).

Copy link
Member

@filippocarletti filippocarletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the IP inside the range supported or not? Is it simply discouraged?
What happens if the IP is inside the range? Does the service start or not? Does it behave unpredictably?
If it is not supported it should be forbidden by the User Interface, not by a note in the manual.

@cotosso
Copy link
Collaborator Author

cotosso commented Feb 18, 2025

Is the IP inside the range supported or not? Is it simply discouraged? What happens if the IP is inside the range? Does the service start or not? Does it behave unpredictably? If it is not supported it should be forbidden by the User Interface, not by a note in the manual.

Of course it should be forbidden by the User Interface, but why not have both?
This way I can already configure the dhcp well and avoid problems in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants