Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(port forward): removing tooltip for disabled port forwards #489

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix(port forward): removing tooltip for disabled port forwards #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 2 additions & 32 deletions src/components/standalone/firewall/PortForwardTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<script setup lang="ts">
import { useI18n } from 'vue-i18n'
import type { PortForward } from '@/views/standalone/firewall/PortForward.vue'
import { toRefs, computed } from 'vue'
import { toRefs } from 'vue'
import {
NeDropdown,
NeTable,
Expand All @@ -15,11 +15,8 @@ import {
NeTableBody,
NeTableRow,
NeTableCell,
NeButton,
NeTooltip,
NeBadge
NeButton
} from '@nethesis/vue-components'
import { useObjectStore } from '@/stores/standalone/objects'
import ObjectTooltip from '@/components/standalone/users_objects/ObjectTooltip.vue'

const { t } = useI18n()
Expand All @@ -31,13 +28,6 @@ const props = defineProps<{

const { portForwards, header } = toRefs(props)

const objects = useObjectStore()

// Computed property to check if the header contains a hyphen
const hasHyphen = computed(() => {
return header.value.includes('-')
})

const emit = defineEmits([
'port-forward-duplicate',
'port-forward-toggle-enable',
Expand Down Expand Up @@ -127,26 +117,6 @@ function getCellClasses(item: PortForward) {
<NeTableRow v-for="item in portForwards" :key="item.id">
<NeTableCell :data-label="t('standalone.port_forward.name')">
<p :class="[...getCellClasses(item)]">{{ item.name }}</p>
<div v-if="hasHyphen">
<NeTooltip triggerEvent="mouseenter focus" placement="top-start">
<template #trigger>
<NeBadge
kind="warning"
size="xs"
class="mt-2"
:icon="['fas', 'triangle-exclamation']"
:text="t('standalone.port_forward.inactive')"
/>
</template>
<template #content>
{{
t('standalone.port_forward.range_object_not_compatible', {
name: objects.getRecord(item.ns_dst ?? '')?.name || '-'
})
}}
</template>
</NeTooltip>
</div>
</NeTableCell>
<NeTableCell :data-label="t('standalone.port_forward.source_port')">
<p :class="[...getCellClasses(item)]">
Expand Down
4 changes: 1 addition & 3 deletions src/i18n/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,9 +1355,7 @@
"restricted_object": "Restricted object",
"restricted_object_tooltip": "All objects supported, except host sets with IP ranges",
"no_object": "No object",
"port_forwards_for_destination_name": "Port forwards for destination '{name}'",
"inactive": "Inactive",
"range_object_not_compatible": "This port forward is inactive because host set '{name}' includes an IP range"
"port_forwards_for_destination_name": "Port forwards for destination '{name}'"
},
"firewall_rules": {
"title": "Firewall rules",
Expand Down