Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(softwareCenter): add release note URLs for GitHub code repositories #795

Merged
merged 16 commits into from
Feb 3, 2025

Conversation

stephdl
Copy link
Contributor

@stephdl stephdl commented Jan 29, 2025

Introduce functionality to set release note URLs for modules sourced from GitHub repositories, enhancing the documentation accessibility for users.

NethServer/dev#7243

  {
    "name": "Mattermost",
    "description": {
      "en": "Mattermost is a secure Open Source chat for team collaboration.",
      "it": "Mattermost è una chat Open Source sicura per la collaborazione in team."
    },
    "logo": "https://distfeed.nethserver.org/ns8/updates/mattermost/logo.png",
    "screenshots": [
      "https://distfeed.nethserver.org/ns8/updates/mattermost/screenshots/screen1.png"
    ],
    "categories": [
      "collaboration"
    ],
    "authors": [
      {
        "name": "de Labrusse Stéphane",
        "email": "[email protected]"
      }
    ],
    "docs": {
      "documentation_url": "https://docs.mattermost.com/",
      "bug_url": "https://github.com/NethServer/dev",
      "code_url": "https://github.com/NethServer/ns8-mattermost",
      "relnotes_url": "https://github.com/NethServer/ns8-mattermost/releases"
    },
    "source": "ghcr.io/nethserver/mattermost",
    "versions": [
      {
        "tag": "2.1.1",
        "testing": false,
        "labels": {
          "io.buildah.version": "1.23.1",
          "org.nethserver.authorizations": "node:fwadm traefik@node:routeadm",
          "org.nethserver.images": "docker.io/postgres:13.13-alpine docker.io/mattermost/mattermost-team-edition:9.11.6",
          "org.nethserver.rootfull": "0",
          "org.nethserver.tcp-ports-demand": "2",
          "org.nethserver.udp-ports-demand": "1"
        }
      }
    ],
    "id": "mattermost",
    "repository": "default",
    "repository_updated": "Tue, 28 Jan 2025 18:42:14 GMT",
    "repository_authority": "distfeed.nethserver.org",
    "certification_level": 4,
    "rootfull": false,
    "disabled_updates_reason": "",
    "installed": [],
    "updates": [],
    "install_destinations": [
      {
        "node_id": 1,
        "instances": 0,
        "eligible": true,
        "reject_reason": null
      }
    ]
  },

@@ -130,6 +131,10 @@
"code_url": {
"type": "uri",
"description": "Link to the source code repository"
},
"relnotes_url": {
"type": "uri",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this type is not defined in draft-07 and we must fix it here and elsewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be good

github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst the change of repo metadata schema is safe, changing the API list-modules output validator can introduce regressions.

github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
@stephdl stephdl requested a review from andre8244 January 30, 2025 12:58
core/ui/public/i18n/en/translation.json Outdated Show resolved Hide resolved
core/ui/src/views/SoftwareCenterAppInstances.vue Outdated Show resolved Hide resolved
core/ui/src/views/SoftwareCenterAppInstances.vue Outdated Show resolved Hide resolved
core/ui/src/views/SoftwareCenterCoreApps.vue Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
@stephdl stephdl requested a review from andre8244 January 30, 2025 15:21
"
class="row"
>
<cv-link
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use a standard <a href="..." here and remove class="row icon-and-text"

>{{ $t("common.release_notes") }} <Launch20
/></cv-link>
>
<NsButton kind="ghost" :icon="Launch20">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@stephdl stephdl merged commit e1ec23d into main Feb 3, 2025
3 checks passed
@stephdl stephdl deleted the sdl-7243 branch February 3, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants