-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(softwareCenter): add release note URLs for GitHub code repositories #795
Conversation
Co-authored-by: Davide Principi <[email protected]>
@@ -130,6 +131,10 @@ | |||
"code_url": { | |||
"type": "uri", | |||
"description": "Link to the source code repository" | |||
}, | |||
"relnotes_url": { | |||
"type": "uri", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid this type is not defined in draft-07 and we must fix it here and elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be good
…AppModal and SoftwareCenterAppInstances
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst the change of repo metadata schema is safe, changing the API list-modules output validator can introduce regressions.
core/imageroot/var/lib/nethserver/cluster/actions/list-modules/validate-output.json
Outdated
Show resolved
Hide resolved
" | ||
class="row" | ||
> | ||
<cv-link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use a standard <a href="..."
here and remove class="row icon-and-text"
>{{ $t("common.release_notes") }} <Launch20 | ||
/></cv-link> | ||
> | ||
<NsButton kind="ghost" :icon="Launch20"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Introduce functionality to set release note URLs for modules sourced from GitHub repositories, enhancing the documentation accessibility for users.
NethServer/dev#7243