Support for additional ImageSamplerDescriptor properties (Fixes #215) #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcwalton
added a commit
to pcwalton/bevy_asset_loader
that referenced
this pull request
Oct 14, 2024
This is a less ambitious version of NiklasEi#216 that should be ready to go. It changes `#[image(sampler = linear)]` and `#[image(sampler = nearest)]` to `#[image(sampler(filter = linear))]` and `#[image(sampler(filter = nearest))]` respectively. The `sampler` list also supports `repeat` and `clamp` modes. So, for example, you can write `#[image(sampler(filter = linear, repeat)]` or `#[image(sampler(repeat))]`. Closes NiklasEi#235.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not a Rust expert so there's probably a cleaner ways of doing things!
There's quite a lot of boilerplate to get internal Bevy enums working with the derive parameters and I think that could be tidied up with macros, but I figured I'd wait to see the feedback on this before working on it.