only set default values for nix-path if nothing else is set
#11429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
fricklerhandwerk
force-pushed
the
nix-path-bug
branch
from
b499e3a
to
9eb6355
Compare
|
@Ericson2314 This is weird, the tests should fail. I noticed this locally too, but assumed that I'm doing it wrong, but apparently something is wrong with the tests? |
TODO: this doesn't work yet. we currently have no way of checking if a config value was set or not. this is the expected behavior for default values: new values should override them, not prepend. the change fixes a logic bug introduced when fixing the previously confused override mechanism in e062021.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-09-09-nix-team-meeting-minutes-176-175/51852/1 |
|
In today's meeting we've determined that the entries are only added when actually present in e.g. |
fricklerhandwerk
force-pushed
the
nix-path-bug
branch
from
9eb6355
to
2754111
Compare
fricklerhandwerk
force-pushed
the
nix-path-bug
branch
from
0b4a6ed
to
1f032a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: this doesn't work yet.
we currently have no way of checking if a config value was set or not.
Motivation
this is the expected behavior for default values:
new values should override them, not prepend.
Context
the change fixes a logic bug introduced when fixing the previously confused
override mechanism in e062021.
thanks @roberth for pointing it out:
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.