sequoia-nixbld-user-migration: nail down PATH #12258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a user report of trouble with toybox grep and avoids potential of same basic issue with other utils.
abathur
commented
Jan 15, 2025
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| set -eo pipefail | |||
|
|
|||
| # stock path to avoid unexpected command versions | |||
| PATH="$(/usr/bin/getconf PATH)" | |||
There was a problem hiding this comment.
This should yield a standard system PATH. For context, here's what it outputs on mine:
$ getconf PATH
/usr/bin:/bin:/usr/sbin:/sbin
edolstra
added
backport 2.24-maintenance
This was referenced Jan 16, 2025
mergify bot
added a commit
that referenced
this pull request
Jan 16, 2025
…2258 sequoia-nixbld-user-migration: nail down PATH (backport #12258)
roberth
added
automatic backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes user-reported trouble caused by toybox grep on PATH in the script for migrating the UIDs of nixbld users for macOS Sequoia and avoids same basic issue with other utils.
Context
For most-relevant context see comments between these two links (inclusive):
If needed, the whole thread those comments are in provides context on the purpose of the migration script.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.