Store::getFSAccessor: Do not include the store dir
#12531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-cli
Ericson2314
commented
Feb 20, 2025
| @@ -21,7 +21,7 @@ nix shell -f shell-hello.nix 'hello^*' -c hello2 | grep 'Hello2' | |||
| nix shell -f shell-hello.nix hello-symlink -c hello | grep 'Hello World' | |||
|
|
|||
| # Test that symlinks outside of the store don't work. | |||
| expect 1 nix shell -f shell-hello.nix forbidden-symlink -c hello 2>&1 | grepQuiet "is not in the Nix store" | |||
| expect 1 nix shell -f shell-hello.nix forbidden-symlink -c hello 2>&1 | grepQuiet "points outside source accessor" | |||
There was a problem hiding this comment.
N.B. error message is quite arguably worse.
On the other hand, this error message should be something that can occur in other contexts for other reasons (e.g. symlinks escaping fetch-tree'd source), in which case having the same message to show the commonality is good.
The fullt expanded messages has all the relevant paths, so the user will still see /nix/store.
Ericson2314
force-pushed
the
store-accessor-root
branch
2 times, most recently
from
e98041b to
ca13970
Compare
puffnfresh
reviewed
Feb 20, 2025
Ericson2314
force-pushed
the
store-accessor-root
branch
from
ca13970 to
ac1b340
Compare
roberth
reviewed
Feb 20, 2025
There was one `inputs.nixFmt` left after 573ffac.
Rather than "mounting" the store inside an empty virtual filesystem, just return the store as a virtual filesystem. This is more modular. (FWIW, it also supports two long term hopes of mind: 1. More capability-based Nix language mode. I dream of a "super pure eval" where you can only use relative path literals (See NixOS#8738), and any `fetchTree`-fetched stuff + the store are all disjoint (none is mounted in another) file systems. 2. Windows, where the store dir may include drive letters, etc., and is thus unsuitable to be the prefix of any `CanonPath`s. )
Ericson2314
force-pushed
the
store-accessor-root
branch
from
ac1b340 to
c811b33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Rather than "mounting" the store inside an empty virtual filesystem,
just return the store as a virtual filesystem. This is more modular.
Context
FWIW, it also supports two long term hopes of mind:
More capability-based Nix language mode. I dream of a "super pure
eval" where you can only use relative path literals (See
no-absolute-path-literalsexperimental feature #8738), andany
fetchTree-fetched stuff + the store are all disjoint (none ismounted in another) file systems.
Windows, where the store dir may include drive letters, etc., and is
thus unsuitable to be the prefix of any
CanonPaths.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.