Fix perl store bindings (backport #12543) #12545
Open
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Hydra currently fails to show the build dependencies of it's builds (NixOS/hydra#1401) with an error like this:
The invalid path the error is referring to, is produced in the current Perl bindings itself.
Context
When #9863 converted the
Nix::Store
free functions into member functions, the implicitthis
argument was not accounted for when iterating over the variable number of arguments in some functions.The following functions are affected:
computeFSClosure
topoSortPaths
(this causes the hydra error)exportPaths
flake.nix
reproducing the error:Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
This is an automatic backport of pull request #12543 done by [Mergify](https://mergify.com).