more tests

Signed-off-by: lucasew <[email protected]>

tests/nowith-nixos-submodule-shadow/default.nix

@@ -0,0 +1 @@
+import <test-nixpkgs> { root = ./.; }

tests/nowith-nixos-submodule-shadow/expected

@@ -0,0 +1 @@
+- test.nix: Top level with is discouraged as it may shadow variables and break static checks.

tests/nowith-nixos-submodule-shadow/test.nix

@@ -0,0 +1,38 @@
+{ config
+, lib
+}:
+
+let
+  cfg = config.foo;
+in {
+  options.foo = lib.mkOption {
+    type = # random example from nixpkgs
+      with lib.types;
+      attrsOf (
+        either path (submodule {
+          options = {
+            service = lib.mkOption {
+              type = nullOr str;
+              default = null;
+              description = "The service on which to perform \<action\> after fetching.";
+            };
+
+            action = lib.mkOption {
+              type = addCheck str (
+                x:
+                cfg.svcManager == "command"
+                || lib.elem x [
+                  "restart"
+                  "reload"
+                  "nop"
+                ]
+              );
+              default = "nop";
+              description = "The action to take after fetching.";
+            };
+          };
+        })
+      );
+    };
+}
+

tests/nowith-nixos-submodule-unshadow-inherit/default.nix

@@ -0,0 +1 @@
+import <test-nixpkgs> { root = ./.; }

tests/nowith-nixos-submodule-unshadow-inherit/expected

@@ -0,0 +1 @@
+Validated successfully

tests/nowith-nixos-submodule-unshadow-inherit/test.nix

@@ -0,0 +1,52 @@
+{ config
+, lib
+}:
+
+let
+  cfg = config.foo;
+
+  inherit (lib)
+    mkOption
+    elem
+  ;
+
+  inherit (lib.types)
+    attrsOf
+    either
+    path
+    submodule
+    nullOr
+    str
+    addCheck
+  ;
+in {
+  options.foo = mkOption {
+    type = # random example from nixpkgs
+      attrsOf (
+        either path (submodule {
+          options = {
+            service = mkOption {
+              type = nullOr str;
+              default = null;
+              description = "The service on which to perform \<action\> after fetching.";
+            };
+
+            action = mkOption {
+              type = addCheck str (
+                x:
+                cfg.svcManager == "command"
+                || elem x [
+                  "restart"
+                  "reload"
+                  "nop"
+                ]
+              );
+              default = "nop";
+              description = "The action to take after fetching.";
+            };
+          };
+        })
+      );
+    };
+}
+

tests/nowith-nixos-submodule-unshadow/default.nix

@@ -0,0 +1 @@
+import <test-nixpkgs> { root = ./.; }

tests/nowith-nixos-submodule-unshadow/expected

@@ -0,0 +1 @@
+Validated successfully

tests/nowith-nixos-submodule-unshadow/test.nix

@@ -0,0 +1,37 @@
+{ config
+, lib
+}:
+
+let
+  cfg = config.foo;
+in {
+  options.foo = lib.mkOption {
+    type = # random example from nixpkgs
+      lib.types.attrsOf (
+        lib.types.either lib.types.path (lib.types.submodule {
+          options = {
+            service = lib.mkOption {
+              type = lib.types.nullOr lib.types.str;
+              default = null;
+              description = "The service on which to perform \<action\> after fetching.";
+            };
+
+            action = lib.mkOption {
+              type = lib.types.addCheck lib.types.str (
+                x:
+                cfg.svcManager == "command"
+                || lib.elem x [
+                  "restart"
+                  "reload"
+                  "nop"
+                ]
+              );
+              default = "nop";
+              description = "The action to take after fetching.";
+            };
+          };
+        })
+      );
+    };
+}
+