catppuccin-cursors: 0.2.0 -> 0.2.1 #315310
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
|
Result of 65 packages built:
|
getchoo
added
the
12.approvals: 1
|
Thanks for the PR!
Now would indeed be a good time for refactors. What exactly do you have in mind? Personally, I don't think the build time is too much of an issue since the outputs are cached on Nixpkgs' binary cache. |
In relation to #298926 (comment), I was thinking of making |
isabelroses
force-pushed
the
update-ctp-cursors
branch
from
1577923 to
914a9ca
Compare
There was a problem hiding this comment.
Result of nixpkgs-review pr 315310 run on x86_64-linux 1
65 packages built:
- catppuccin-cursors
- catppuccin-cursors.frappeBlue
- catppuccin-cursors.frappeDark
- catppuccin-cursors.frappeFlamingo
- catppuccin-cursors.frappeGreen
- catppuccin-cursors.frappeLavender
- catppuccin-cursors.frappeLight
- catppuccin-cursors.frappeMaroon
- catppuccin-cursors.frappeMauve
- catppuccin-cursors.frappePeach
- catppuccin-cursors.frappePink
- catppuccin-cursors.frappeRed
- catppuccin-cursors.frappeRosewater
- catppuccin-cursors.frappeSapphire
- catppuccin-cursors.frappeSky
- catppuccin-cursors.frappeTeal
- catppuccin-cursors.frappeYellow
- catppuccin-cursors.latteBlue
- catppuccin-cursors.latteDark
- catppuccin-cursors.latteFlamingo
- catppuccin-cursors.latteGreen
- catppuccin-cursors.latteLavender
- catppuccin-cursors.latteLight
- catppuccin-cursors.latteMaroon
- catppuccin-cursors.latteMauve
- catppuccin-cursors.lattePeach
- catppuccin-cursors.lattePink
- catppuccin-cursors.latteRed
- catppuccin-cursors.latteRosewater
- catppuccin-cursors.latteSapphire
- catppuccin-cursors.latteSky
- catppuccin-cursors.latteTeal
- catppuccin-cursors.latteYellow
- catppuccin-cursors.macchiatoBlue
- catppuccin-cursors.macchiatoDark
- catppuccin-cursors.macchiatoFlamingo
- catppuccin-cursors.macchiatoGreen
- catppuccin-cursors.macchiatoLavender
- catppuccin-cursors.macchiatoLight
- catppuccin-cursors.macchiatoMaroon
- catppuccin-cursors.macchiatoMauve
- catppuccin-cursors.macchiatoPeach
- catppuccin-cursors.macchiatoPink
- catppuccin-cursors.macchiatoRed
- catppuccin-cursors.macchiatoRosewater
- catppuccin-cursors.macchiatoSapphire
- catppuccin-cursors.macchiatoSky
- catppuccin-cursors.macchiatoTeal
- catppuccin-cursors.macchiatoYellow
- catppuccin-cursors.mochaBlue
- catppuccin-cursors.mochaDark
- catppuccin-cursors.mochaFlamingo
- catppuccin-cursors.mochaGreen
- catppuccin-cursors.mochaLavender
- catppuccin-cursors.mochaLight
- catppuccin-cursors.mochaMaroon
- catppuccin-cursors.mochaMauve
- catppuccin-cursors.mochaPeach
- catppuccin-cursors.mochaPink
- catppuccin-cursors.mochaRed
- catppuccin-cursors.mochaRosewater
- catppuccin-cursors.mochaSapphire
- catppuccin-cursors.mochaSky
- catppuccin-cursors.mochaTeal
- catppuccin-cursors.mochaYellow
isabelroses
added
12.approvals: 2
Some standardization would be nice. Thanks for working on that! My concern with overrides is that only the default flavor and accent(s) will make it to Nixpkgs' binary cache. If users override the package, Nix will have to build it from scratch. Currently, Personally, I'm fine with either approach since I build my configuration in CI, but if there are many catppuccin packages that are built from source and require overriding, the build times could add up for a user. |
That's a good catch. I didn't even think of this. Though the build time is significantly reduced by only building one or two accent's per theme, which might balance this out a bit more. |
|
fyi this breaks your cursor theme unless you update ...
home.file.".icons/default".source = "${pkgs.catppuccin-cursors.mochaDark}/share/icons/Catppuccin-Mocha-Dark-Cursors";
...To ...
home.file.".icons/default".source = "${pkgs.catppuccin-cursors.mochaDark}/share/icons/catppuccin-mocha-dark-cursors";
...Notice it is lower case now |
This was also discussed on the actual commit 914a9ca#commitcomment-142817963 |
|
Just for others that might not check that and was wondering why their cursor theme is suddenly broken :P |
Description of changes
We now have to build from source since zips are no longer supplied from the main repo. I decided to not break the current apis however there is now room here to refactor the build to be more like catppuccin-gtk, which maybe preferred for smaller build times. For reference the current build time ~5mins.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.