salt: fix urllib.parse module #372604
Merged
salt: fix urllib.parse module #372604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/upgrade-to-24-11-gives-issue-in-salt/57735/2 |
Flakebi
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Looks good to me, thanks.
Looks like there is a fix in progress upstream: saltstack/salt#66899
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 372604
x86_64-linux
✅ 4 packages built:
- python312Packages.pytest-testinfra
- python312Packages.pytest-testinfra.dist
- salt
- salt.dist
|
Please apply the patch and stick with the default Python version. |
wegank
added
12.approvals: 1
SpiritLooper
force-pushed
the
fix-salt-top-sls-not-found
branch
5 times, most recently
from
4958e0d to
34955e2
Compare
SuperSandro2000
changed the title
|
As @mweinelt advised, I applied the patch from Fedora mainstream and revert my previous commit. |
|
Can you use |
wegank
removed
the
12.approvals: 1
SpiritLooper
force-pushed
the
fix-salt-top-sls-not-found
branch
from
34955e2 to
5ef56b8
Compare
|
I get a hash-mismatch for the patch: |
SpiritLooper
force-pushed
the
fix-salt-top-sls-not-found
branch
from
5ef56b8 to
55e1713
Compare
Flakebi
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 372604
x86_64-linux
✅ 4 packages built:
- python312Packages.pytest-testinfra
- python312Packages.pytest-testinfra.dist
- salt
- salt.dist
wegank
added
the
12.approvals: 1
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrograding python package version from 3.12 to 3.10.
Since the upgrade to version 24.11, Salt has exhibited strange behavior with SLS files:
In salt’s GitHub workflow, we can see that salt has been tested with Python 3.10.
Retrograding python to the tested version resolves the issues.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.