Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-bindata-assetfs: unstable-2022-04-12 -> unstable-2025-02-01 #383987

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maddiehorger-fr
Copy link

go-bindata-assetfs has had multiple recent improvements (expanded test suite, bug fixes) upstream. There's also been a bit of a packaging issue on the nixpkgs side: go-bindata-assetfs depends on go-bindata being in $PATH, so as a Nix package, it should bake in a dependency on a pinned version of go-bindata.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from avnik February 21, 2025 16:38
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Feb 21, 2025
@maddiehorger-fr maddiehorger-fr force-pushed the go-bindata-assetfs-unstable-2025-02-01 branch from 5edc936 to e9da203 Compare February 21, 2025 16:41
@maddiehorger-fr
Copy link
Author

Sorry about the force push, I somehow forgot to nixfmt. That's squashed into the commit now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants