Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navidrome: 0.54.3 -> 0.54.5 #383996

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

duxovni
Copy link
Contributor

@duxovni duxovni commented Feb 21, 2025

Upgrades navidrome to version 0.54.5, which contains an important security fix: https://github.com/navidrome/navidrome/releases/tag/v0.54.5

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tebriel
Copy link
Contributor

tebriel commented Feb 21, 2025

@duxovni since this is a pretty critical vulnerability I think we should backport this change, what do you think?

@duxovni
Copy link
Contributor Author

duxovni commented Feb 21, 2025

Yup, definitely agreed.

Copy link
Contributor

@ChandlerSwift ChandlerSwift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working (x86_64).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants