Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] crm_lead_code: Migration to 18.0 #609

Open
wants to merge 36 commits into
base: 18.0
Choose a base branch
from
Open

[MIG] crm_lead_code: Migration to 18.0 #609

wants to merge 36 commits into from

Conversation

HeliconiaSolutions
Copy link

No description provided.

bhaveshselarka
bhaveshselarka approved these changes Nov 27, 2024
View reviewed changes
Copy link

@bhaveshselarka bhaveshselarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review, LGTM

CRogos
CRogos reviewed Feb 20, 2025
View reviewed changes
Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you cleanup the bot commits? I've marked some examples, but there are more.
image

I hope the the push will also recreate the runboat for testing

@HeliconiaSolutions HeliconiaSolutions force-pushed the 18.0-mig-crm_lead_code branch 2 times, most recently from f6d7aea to 6d4d297 Compare February 21, 2025 05:06
@HeliconiaSolutions
Copy link
Author

@CRogos , Please review.it's done!

@CRogos
Copy link

CRogos commented Feb 21, 2025

There are still more commits which can be merged.
Here is a link to the migration documentation: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

sbidoul and others added 17 commits February 21, 2025 17:41
@sbidoul @HeliconiaSolutions
remove obsolete .pot files [ci skip]
8745d41
@marylla @HeliconiaSolutions
Translated using Weblate (German)
cdcd51a 
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-10.0/crm-10.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-10-0/crm-10-0-crm_lead_code/de/
@keshrath @HeliconiaSolutions
[MIG] crm_lead_code: Migration to 12.0
94a4659 
[UPD] Update crm_lead_code.pot
@oca-transbot @HeliconiaSolutions
Update translation files
081a5ad 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: crm-12.0/crm-12.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_code/
@HeliconiaSolutions
Translated using Weblate (Portuguese (Brazil))
d653991 
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-12.0/crm-12.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_code/pt_BR/
@murtuzasaleh @HeliconiaSolutions
[WIP][13.0][MIG] crm_lead_code
e7d8631
@murtuzasaleh @HeliconiaSolutions
[FIX] Travis
9af2c53 
[UPD] Update crm_lead_code.pot

[UPD] README.rst
@oca-transbot @HeliconiaSolutions
Update translation files
38b1fe0 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: crm-13.0/crm-13.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_lead_code/
@newtratip @HeliconiaSolutions
[MIG] crm_lead_code: Migration to 14.0
5a6c454 
[UPD] Update crm_lead_code.pot
@ibuioli @HeliconiaSolutions
Added translation using Weblate (Spanish (Argentina))
4a6ce2b
@ibuioli @HeliconiaSolutions
Translated using Weblate (Spanish (Argentina))
2c1437e 
Currently translated at 100.0% (6 of 6 strings)

Translation: crm-14.0/crm-14.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_lead_code/es_AR/
@Mat-moran @HeliconiaSolutions
Translated using Weblate (Spanish)
dc30b56 
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-14.0/crm-14.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_lead_code/es/
@santostelmo @HeliconiaSolutions
[MIG] crm_lead_code: Migration to 15.0
cbc0b19
@Noel000 @HeliconiaSolutions
Added translation using Weblate (Catalan)
bc6caf7
@ajaniszewska-dev @HeliconiaSolutions
Translated using Weblate (French)
ce107ba 
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-15.0/crm-15.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_lead_code/fr/
@Noel000 @HeliconiaSolutions
Translated using Weblate (Catalan)
b64bbe0 
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-15.0/crm-15.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_lead_code/ca/
@francesco-ooops @HeliconiaSolutions
Translated using Weblate (Italian)
25eb39e 
Currently translated at 66.6% (2 of 3 strings)

Translation: crm-15.0/crm-15.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_lead_code/it/
Jaen and others added 13 commits February 21, 2025 17:41
@HeliconiaSolutions
[MIG] crm_lead_code: Migration to 16.0
6a9c378
@HeliconiaSolutions
[UPD] Update crm_lead_code.pot
5bb5854
@weblate @HeliconiaSolutions
Update translation files
f0ff810 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: crm-16.0/crm-16.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/
@sysadminmatmoz @HeliconiaSolutions
Translated using Weblate (Slovenian)
fa63c1a 
Currently translated at 25.0% (1 of 4 strings)

Translation: crm-16.0/crm-16.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/sl/
@mymage @HeliconiaSolutions
Translated using Weblate (Italian)
e991cfb 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-16.0/crm-16.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/it/
@Ivorra78 @HeliconiaSolutions
Translated using Weblate (Spanish)
a00d4e9 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-16.0/crm-16.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/es/
@ibuioli @HeliconiaSolutions
Translated using Weblate (Spanish (Argentina))
5308003 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-16.0/crm-16.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_lead_code/es_AR/
@peluko00 @HeliconiaSolutions
[MIG] crm_lead_code: Migration to 17.0
698d145
@HeliconiaSolutions
Translated using Weblate (Portuguese (Brazil))
0f26709 
Currently translated at 75.0% (3 of 4 strings)

Translation: crm-17.0/crm-17.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_lead_code/pt_BR/
@SottomaiorMacedoTec @HeliconiaSolutions
Translated using Weblate (Portuguese (Brazil))
a201763 
Currently translated at 100.0% (4 of 4 strings)

Translation: crm-17.0/crm-17.0-crm_lead_code
Translate-URL: https://translation.odoo-community.org/projects/crm-17-0/crm-17-0-crm_lead_code/pt_BR/
@CRogos @HeliconiaSolutions
[IMP] crm_lead_code: space get removed when other view changes name f…
d9ad77d 
…ield
@HeliconiaSolutions
[IMP] crm_lead_code: pre-commit auto fixes
c3d2780
@HeliconiaSolutions
[MIG] crm_lead_code: Migration to 18.0
8fe6ace
@HeliconiaSolutions
Copy link
Author

@CRogos, Please review!

@CRogos
Copy link

CRogos commented Feb 21, 2025

do you know why the tests are failing? Maybe we should make a rebase?

also there are still some weblate and oca-* commits.

CRogos
CRogos approved these changes Feb 21, 2025
View reviewed changes
Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM and it is working.

Not sure why the tests fail, and some Commits can still be squashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRogos CRogos CRogos approved these changes

@bhaveshselarka bhaveshselarka bhaveshselarka approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.