[17.0] [IMP] fieldservice_account_analytic: Invoice customer not related to any location

[brian10048]

Port of #1322

[OCA-git-bot]

Hi @bodedra, @osimallen,
some modules you are maintaining are being modified, check this out!

[BernatObrador]

Maybe this onchange can be set like this instead of deleting it:

@api.onchange("customer_id")
def _onchange_customer_id(self):
      if self.customer_id.fsm_location_id:
            self.location_id = self.customer_id.fsm_location_id
      else:
            self.location_id = False

This approach would avoid potential buggy behaviors like:

1. Creating an FSM order.
2. Selecting a location.
3. Changing the customer to one without a location.
4. Clicking on the Location internal link.
   

However, I'm not sure if a customer can be delivered to a different location than their own.
What do you think about this approach?

[BernatObrador]

Another solution could be changing the context of the field to let the user freely select the location.

I guess it's just needed to delete this:

<field name="location_id" position="attributes">
                <attribute name="context">{"customer_id": customer_id}</attribute>
</field>