[17.0][FW] fieldservice: multiple ports from 16.0 #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type mix-up was provoking infinite loops when navigating out of form views with "next" arrow buttons. Fixes OCA#1161.
Read-only+required partner field shown in debug mode was preventing manual creation in debug mode or with OCA module base_technical_features.
Service locations `fsm.location` create a partner `res.partner` through inheritance. Before this change, partners could be explicitely typed "fsm_location" when adding them within children of an existing partner, which in turn would automatically create service locations on top of them. But creating a service location by hand would not set that type on the partner created through inheritance. After this change, all partners built from service locations are typed the same. Fixes OCA#1128.
Before this change, service location partners (created through inheritance) were typed "fsm_location" but did not always have a parent. When adding them within children of an existing partner, they of course did have a parent, but not the other way around: they had no parents when created, through inheritance, upon service location creation. After this change, service location partners are by default children of the service location owner partner. This is only done through defaults but not as related fields, which would break too much. Therefore, existing partners are not impacted by this change; only new ones created when creating a service location. See OCA#1128.
Update scheduled_date_start field not date_start field
OCA#1166 also in 16.0
|
Hi @max3903, |
brian10048
force-pushed
the
oca-port-fieldservice-16.0-to-17.0-90539d
branch
2 times, most recently
from
d208fd9 to
a1542d7
Compare
compute method should depend on fields used in the calculation
Improve fsm.category parent/child relationship and optimize for search and views
Silences the following warning: WARNING ? odoo.models: parent_path field on model 'fsm.category' should have unaccent disabled. Add `unaccent=False` to the field definition.
brian10048
force-pushed
the
oca-port-fieldservice-16.0-to-17.0-90539d
branch
3 times, most recently
from
5685b3e to
a57d184
Compare
brian10048
force-pushed
the
oca-port-fieldservice-16.0-to-17.0-90539d
branch
from
c0652c5 to
1a8cce4
Compare
|
@victoralmau whenever I introduce this commit a425291 the tests hang up on test_fsm_order.py . I'm not too familiar with freeze_time, is there something that should be done differently? |
Ok, I see, the way to solve it is the following:
Actually this “problem” is not explained anywhere, but I have discovered it recently and it happens when tests are run post-install. |
|
@victoralmau that was it! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from 16.0 to 17.0: