Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] new module pos_check_accounting_settings to avoid launching new PoS session with incorrect configuration. #1209

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Jun 29, 2024

This module extends the functionnality of Odoo PoS adding extra checks, when opening session, to ensure that accounting configation is correct.

Use case 1

When we create a payment method and if :

  • the field 'Outstanding Payment' is not set on payment method
  • AND the field 'Outstanding Receipts Account' is not on company

if we use the payment method in the Point of sale, it is not possible to close the session after.

error_oustanding_payment

As it not possible to change a payment method when a session is not closed, this bad configuration has to be fixed by SQL.

This module adds a check when opening session, to avoid such situation.

@legalsylvain legalsylvain added this to the 16.0 milestone Jun 29, 2024
@legalsylvain legalsylvain changed the title [ADD] new module pos_check_accounting_settings to avoid launching new PoS session with incorrect configuration. [16.0][ADD] new module pos_check_accounting_settings to avoid launching new PoS session with incorrect configuration. Jun 29, 2024
@legalsylvain legalsylvain force-pushed the pos_check_accounting_settings branch 4 times, most recently from 53073b9 to 8dee546 Compare June 29, 2024 23:52
@legalsylvain
Copy link
Contributor Author

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@legalsylvain The rebase process failed, because command git push --force grap tmp-pr-1209:pos_check_accounting_settings failed with output:

remote: Permission to grap/pos.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/grap/pos/': The requested URL returned error: 403

@legalsylvain legalsylvain force-pushed the pos_check_accounting_settings branch 2 times, most recently from 5590eae to 6b112e4 Compare July 2, 2024 09:27
@miquelalzanillas
Copy link

@legalsylvain could you rebase please?

@legalsylvain legalsylvain force-pushed the pos_check_accounting_settings branch from 6b112e4 to 314719c Compare October 2, 2024 09:06
Copy link

github-actions bot commented Feb 2, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 2, 2025
@flotho
Copy link
Member

flotho commented Feb 12, 2025

any chance to rebase @legalsylvain ?

…ble with pos_check_accounting_settings_company module
@legalsylvain legalsylvain force-pushed the pos_check_accounting_settings branch from 314719c to 9224c3e Compare February 12, 2025 22:19
@legalsylvain
Copy link
Contributor Author

@miquelalzanillas, @flotho : done !

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants