[18.0][MIG] repair_stock: Migration to 18.0 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeliconiaSolutions
force-pushed
the
18.0-mig-repair_stock
branch
from
7950e0c to
93dc8ba
Compare
This was referenced Jan 6, 2025
|
Hi @HeliconiaSolutions could you cherry-pick this patch #90 here? |
`repair_id` is reserved to the stock.moves directly related to the execution of the repair order and has associated logic in odoo core code (like assigning the picking type) To avoid unexpected behaviors, we use `related_repair_id` to signal auxiliar stock moves that are not directly related to repair execution. To not break existing modules depending on it, support for `repair_id` is kept but it is recommended to remove in v18.
|
@LoisRForgeFlow , please review.it's done. |
Comment on lines
+30
to
+32
| # TODO: migration note: `repair_id` should not be used here | ||
| # in v18, use `related_repair_id` instead while migrating | ||
| # modules depending on this. |
There was a problem hiding this comment.
Could you attend this? I think we should only rely on related_repair_id now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.