Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] rma: _get_sequence_values signature #366

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[16.0][FIX] rma: _get_sequence_values signature #366

merged 1 commit into from
Sep 6, 2023

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Sep 6, 2023 •
edited
Loading

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 6, 2023
pedrobaeza
pedrobaeza reviewed Sep 6, 2023
View reviewed changes
rma/models/stock_warehouse.py Outdated
def _get_sequence_values(self):
values = super()._get_sequence_values()
def _get_sequence_values(self, name=False, code=False):
values = super()._get_sequence_values(name, code)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always pass the keyword arguments as keyword:

Suggested change
values = super()._get_sequence_values(name, code)
values = super()._get_sequence_values(name=name, code=code)

@pedrobaeza
Copy link
Member

I have noted that uninstalling the module, the sequences remain. Is there any cleanup code for that in standard?

@chienandalu
Copy link
Member Author

I have noted that uninstalling the module, the sequences remain. Is there any cleanup code for that in standard?

Not that I'm aware of. I guess you don't even need to uninstall, but just remove a warehouse and that sequences dirt will stay there forever

@pedrobaeza
Copy link
Member

hahaha: odoo/odoo#134032

@chienandalu
Copy link
Member Author

Oh :)

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-366-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6647b9b into OCA:16.0 Sep 6, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 86e847b. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-fix-rma-method-signature branch September 6, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@victoralmau victoralmau victoralmau approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chienandalu @OCA-git-bot @pedrobaeza @victoralmau