Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] rma: dedicated settings section #428

Merged
merged 1 commit into from
Oct 16, 2024
Merged

[16.0][IMP] rma: dedicated settings section #428

merged 1 commit into from
Oct 16, 2024

Conversation

sbejaoui
Copy link
Contributor

image

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza, @chienandalu,
some modules you are maintaining are being modified, check this out!

chienandalu
chienandalu approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

rma/views/res_config_settings_views.xml Outdated Show resolved Hide resolved
@rousseldenis rousseldenis added this to the 16.0 milestone Oct 16, 2024
rousseldenis
rousseldenis approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chienandalu
chienandalu approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great now! 👍

@pedrobaeza pedrobaeza changed the title [IMP] rma: dedicated settings section [16.0][IMP] rma: dedicated settings section Oct 16, 2024
pedrobaeza
pedrobaeza approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only ugly thing is to have the sample screenshot with enterprise installed, hehe.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-428-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b9e0887 into OCA:16.0 Oct 16, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at db7791a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sbejaoui @OCA-git-bot @chienandalu @pedrobaeza @rousseldenis