[16.0][IMP] sale_order_carrier_auto_assign enable feature settings #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
force-pushed
the
16.0-imp-sale_order_carrier_auto_assign-add-config
branch
from
f5846ca to
0a6fc3e
Compare
simahawk
requested changes
Feb 19, 2024
| cls.env = cls.env["base"].with_context(**DISABLED_MAIL_CONTEXT).env | ||
| cls.settings = cls.env["res.config.settings"].create({}) | ||
| cls.settings.carrier_auto_assign = True | ||
| cls.settings.execute() |
There was a problem hiding this comment.
Suggested change
| cls.settings.execute() | |
| cls.settings.set_values() |
Never use execute. Always use set_values to not trigger a whole not needed machinery that will slow down everything.
|
|
||
|
|
||
| class SaleOrder(models.Model): | ||
|
|
||
| _inherit = "sale.order" | ||
|
|
||
| def action_confirm(self): | ||
| if config["test_enable"] and not self.env.context.get( |
There was a problem hiding this comment.
this is changing the default behavior where ppl expects this to be working OOTB.
It requires an upgrade step to enable it by default on existing installations.
|
I've rebased |
|
Hi @santostelmo, I created camptocamp#34 to improve your PR |
santostelmo
force-pushed
the
16.0-imp-sale_order_carrier_auto_assign-add-config
branch
2 times, most recently
from
f44e997 to
c3b0520
Compare
santostelmo
force-pushed
the
16.0-imp-sale_order_carrier_auto_assign-add-config
branch
from
c3b0520 to
81bdb1c
Compare
|
@santostelmo Looks obsolete. Can this be closed? |
|
Yes let's close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is an improvement of PR:
#2533
It will allow to enable feature via settings