[18.0][FIX] base_tier_validation: Do not update the counter if it is not possible to review it #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssible to review it. Change res_id field (tier.review) to Many2oneReference Example use case: - Create tier definition with Mitchell Admin as reviewer user. - Create a record (purchase.requisition for example) with Marc Demo and request a validation. - Do not update the counter in Marc Demo (because you cannot review it). TT55411
… the validation if you are unable to validate it TT55411
|
Hi @LoisRForgeFlow, |
pedrobaeza
approved these changes
Mar 13, 2025
sergio-teruel
approved these changes
Mar 13, 2025
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 13310ac. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWP from 17.0: #1041
Do not update the counter if it is not possible to review it.
Example use case:
purchase.requisitionfor example) with Marc Demo and request a validation.Before
After
Do not update the counter when restarting the validation if you are unable to validate it.<i/ns>
Before
After
Please @pedrobaeza and @sergio-teruel can you review it?
@Tecnativa TT55411