-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] fs_image #446
Open
rousseldenis
wants to merge
32
commits into
OCA:18.0
Choose a base branch
from
acsone:18.0-mig-fs-image-dro
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] fs_image #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store your image into an external filesystem
Currently translated at 100.0% (14 of 14 strings) Translation: storage-16.0/storage-16.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_image/es/
Currently translated at 92.8% (13 of 14 strings) Translation: storage-16.0/storage-16.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_image/it/
Currently translated at 100.0% (14 of 14 strings) Translation: storage-16.0/storage-16.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_image/it/
Fix a bug in the initialization of the image field value object when the field is read. Before this fix, every time the value object was initialized with an attachment, an assignment of the alt text was done into the constructor. This assignment triggered the mark of the field as modified and an SQL update query was generated at the end of the request. The alt text in the constructor of the FSImageValue class must only be used when the class is initialized without an attachment. We now check if an attachment and an alt text are provided at the same time and throw an exception if this is the case.
rawCacheKey is properly managed by STD
Currently translated at 78.5% (11 of 14 strings) Translation: storage-16.0/storage-16.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_image/fr/
Before this change the creation of empty file was not supported. The issue was mainly due to the fact that at create of a FSFileValue instance with a name but without content, the name was no preserved. As result, the insert of the attachement into the DB failed since the name is a required field. If a FSFileValue instance is now created without content but with a name, the name is now preserved on an empty buffer.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-17.0/storage-17.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_image/
On image hover, a download button is now available to easily download the image
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: storage-17.0/storage-17.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_image/
Currently translated at 100.0% (15 of 15 strings) Translation: storage-17.0/storage-17.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_image/it/
6181721
to
3d05917
Compare
3d05917
to
47b05bb
Compare
/ocabot migration fs_image |
lmignon
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Code review + diff with 16.0 and functional via #449)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: