Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DAO and WOF Timeseries Models to handle Affiliations better #130

Merged
merged 2 commits into from
May 23, 2017
Merged

Update DAO and WOF Timeseries Models to handle Affiliations better #130

merged 2 commits into from
May 23, 2017

Conversation

lsetiawan
Copy link
Member

This PR:

@lsetiawan lsetiawan requested a review from emiliom May 23, 2017 22:28
emiliom
emiliom approved these changes May 23, 2017
View reviewed changes
Copy link
Member

@emiliom emiliom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@emiliom
Copy link
Member

emiliom commented May 23, 2017

Looks good. I'm going to merge the PR now. I assume you did more testing, including testing with the EnviroDIY DB?

@emiliom emiliom merged commit 9fd381c into ODM2:master May 23, 2017
@emiliom
Copy link
Member

emiliom commented May 23, 2017

Updates the odm2timeseries dao to query Affiliations better. #129

Just a comment on this: your PR does more than better handling Affiliations. It fixes the handling of Affiliations!

@emiliom emiliom mentioned this pull request May 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiliom emiliom emiliom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsetiawan @emiliom