Merge pull request #4 from uc-cdis/fix/owner_check_and_remove_dead_code

Fix: better name for isPermittedGlobalShareArtifact
OHDSI · Sep 9, 2024 · 01eca8c · 01eca8c
2 parents b8017b9 + 4872345
commit 01eca8c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/js/pages/cohort-definitions/cohort-definition-manager.js b/js/pages/cohort-definitions/cohort-definition-manager.js
@@ -203,7 +203,7 @@ define(['jquery', 'knockout', 'text!./cohort-definition-manager.html',
 			if (config.enablePermissionManagement) {
 				this.userCanShare = ko.observable(
 						!config.limitedPermissionManagement ||
-						authApi.isPermittedGlobalShareCohort());
+						authApi.isPermittedGlobalShareArtifact());
 			} else {
 				this.userCanShare = ko.observable(false);
 			}

diff --git a/js/pages/concept-sets/conceptset-manager.js b/js/pages/concept-sets/conceptset-manager.js
@@ -179,7 +179,7 @@ define([
 			if (config.enablePermissionManagement) {
 				this.userCanShare = ko.observable(
 						!config.limitedPermissionManagement ||
-						authApi.isPermittedGlobalShareCohort());
+						authApi.isPermittedGlobalShareArtifact());
 			} else {
 				this.userCanShare = ko.observable(false);
 			}

diff --git a/js/services/AuthAPI.js b/js/services/AuthAPI.js
@@ -395,7 +395,7 @@ define(function(require, exports) {
         return isPermitted('cohortdefinition:' + id + ':copy:get');
     }
 
-    var isPermittedGlobalShareCohort = function() {
+    var isPermittedGlobalShareArtifact = function() {
         // special * permission (intended for admins) that allows the
         // user to share any artifact with a "global reader role":
         return isPermitted('artifact:global:share:put');
@@ -592,7 +592,7 @@ define(function(require, exports) {
         isPermittedReadCohort: isPermittedReadCohort,
         isPermittedCreateCohort: isPermittedCreateCohort,
         isPermittedCopyCohort: isPermittedCopyCohort,
-        isPermittedGlobalShareCohort: isPermittedGlobalShareCohort,
+        isPermittedGlobalShareArtifact: isPermittedGlobalShareArtifact,
         isPermittedUpdateCohort: isPermittedUpdateCohort,
         isPermittedDeleteCohort: isPermittedDeleteCohort,
         isPermittedGenerateCohort: isPermittedGenerateCohort,