Dns rust keywords 7529 v7 #12735
Open
Dns rust keywords 7529 v7 #12735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7529 Ticket: 3725 Adds url for dns.opcode on the way Move dns.query unit tests to SV on the way
Ticket: 6723
Ticket: 6723
So that its contents can be reused when translating unit tests to SV tests
catenacyber
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12735 +/- ##
==========================================
+ Coverage 80.76% 80.78% +0.01%
==========================================
Files 936 932 -4
Lines 259724 259832 +108
==========================================
+ Hits 209765 209898 +133
+ Misses 49959 49934 -25
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline 25022 |
|
@jasonish what do you think ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7529
https://redmine.openinfosecfoundation.org/issues/3725
Describe changes:
UTHBuildPacketRealto produce more real packets#11932 next protocol
#12720 with
Cleanupcallback instead of flag SIGMATCH_NEEDS_RUST_FREE