Smb log configurable 7620 v1.1 #12795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will allow rust to list the values of an array such as dns.types for outputs
suricata.yaml output section for smb now parses a types list and will restrict logging of transactions to these types. By default, everything still gets logged Remove unused rs_smb_log_json_request on the way Ticket: 7620
catenacyber
requested review from
victorjulien,
jasonish,
jufajardini and
a team
as code owners
catenacyber
commented
Mar 20, 2025
| @@ -101,6 +105,42 @@ impl ConfNode { | |||
| return Self { conf } | |||
| } | |||
|
|
|||
| pub fn get_child_node(&self, key: &str) -> Option<ConfNode> { | |||
There was a problem hiding this comment.
@jasonish thoughts about this commit ? (wrt to bindgen)
It looks to me that we do not want to have C struct ConfNode exported to rust, but instead just have an opaque pointer and some rust-style functions to handle it, so I went this way
catenacyber
commented
Mar 20, 2025
| @@ -1143,6 +1143,21 @@ SMB Fields | |||
| * "response.native_os" (string): SMB1 native OS string | |||
| * "response.native_lm" (string): SMB1 native Lan Manager string | |||
|
|
|||
| One can restrict which transactions are logged by using the "types" field in the | |||
| suricata.yaml file. If this field is not specified, all transactions types are logged. | |||
| 9 values can be specified with this field as shown below: | |||
catenacyber
commented
Mar 20, 2025
| if let Some(f) = get_smb_log_type_from_str(nodeu.value()) { | ||
| r |= f; | ||
| } else { | ||
| SCLogWarning!("unknown type for smb logging: {}", nodeu.value()); |
There was a problem hiding this comment.
By the way, this should be done for DNS (warn when an unknown type is configured)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12795 +/- ##
==========================================
+ Coverage 80.85% 80.86% +0.01%
==========================================
Files 936 936
Lines 259870 259982 +112
==========================================
+ Hits 210120 210240 +120
+ Misses 49750 49742 -8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
ERROR: ERROR: QA failed on ASAN_TLPR1_suri. Pipeline 25268 |
|
Leak fixed in #12797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7620
Describe changes:
SV_BRANCH=OISF/suricata-verify#2352