Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broke into general log use cases + security use cases. #1633

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

adamshostack
Copy link
Contributor

Brought in a few things that were more clear in the old cs, and did some refactoring. https://wiki.owasp.org/index.php?title=Error_Handling,_Auditing_and_Logging

You're A Rockstar

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as [TEXT](URL)
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR fixes issue #<REPLACE WITH ISSUE NUMBER>.

Thank you again for your contribution 😃

Sorry, something went wrong.

Brought in a few things that were more clear in the old cs, and did some refactoring. https://wiki.owasp.org/index.php?title=Error_Handling,_Auditing_and_Logging
Copy link
Collaborator

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kwwall kwwall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will leave it to you if you want to address the minor punctuation nits that I brought up, but I approve even without those being addressed.

- Establishing baselines
- Assisting non-repudiation controls (note that the trait non-repudiation is hard to achieve for logs because their trustworthiness is often just based on the logging party being audited properly while mechanisms like digital signatures are hard to utilize here)
- Business process monitoring e.g. sales process abandonment, transactions, connections
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like some additional punctuation would be useful here. E.g.,

Business process monitoring; e.g. - sales process abandonment, transactions, connections

- Providing information about problems and unusual conditions
- Contributing additional application-specific data for incident investigation which is lacking in other log sources
- Helping defend against vulnerability identification and exploitation through attack detection
- Performance monitoring e.g. data load time, page timeouts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto in this case as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no argument - if you go in to make the change re alert vs investigations, do you want to roll these into that change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this moment of time, I am not that ambitious. And I think what you have is fine.

Comment on lines +29 to +30
- Identifying security incidents
- Monitoring policy violations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After 25+ years of me working in AppSec with CIRT and/or DFIR teams, I've observed that the CIRT / DFIR teams tend to split the log messages for security use cases into 2 main camps. One are log messages that they will use to trigger alerts (often combined with thresholds), and the other type are log events that is used as forensic evidence which they generally ignore until they open an investigation into a potential breach.

This division referenced here seems to be alluding to that. I'm not saying that we ought to provide more detail here, but was just curious if anyone else had had ever made similar observations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen this, but I think from an advice perspective something like "Ask yourself 'is this a message someone will use to trigger an action, or as part of a larger investigation'?"

- Compliance monitoring
- Data for subsequent requests for information e.g. data subject access, freedom of information, litigation, police and other regulatory investigations
- Legally sanctioned interception of data e.g. application-layer wire-tapping
- Other business-specific requirements
- Contributing additional application-specific data for incident investigation which is lacking in other log sources
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is like the forensics use that I previously mentioned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

- Anti-automation monitoring
- Identifying security incidents
- Monitoring policy violations
- Assisting non-repudiation controls (note that the trait non-repudiation is hard to achieve for logs because their trustworthiness is often just based on the logging party being audited properly while mechanisms like digital signatures are hard to utilize here)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could take up a cheat-sheet topic just on it's own. While it is not easy to achieve, the difficulty varies depending on your specific goals. It also need not require dsigs (e.g., recording logs to a WORM drive doesn't require that.) The bigger question is whether a business would consider this of something of value. To answer that, I think you need to consider it from a cost-benefit perspective and then do a threat model to decide what level of assurance of non-repudiation are you trying to achieve in like of the surfaced threats. That seems just the type of thing that fits in @adamshostack's wheelhouse. 😄

@mackowski mackowski merged commit 9afce02 into OWASP:master Mar 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants