update serviceName to use headless service (#88)

* update serviceName to use headless service * update serviceName to use headless service * add annotations to headless serviec * Update README and values.schema.json for modified charts * add annotations to headless serviec * bump version --------- Co-authored-by: chris-vest <[email protected]> Co-authored-by: Alec Thomas <[email protected]>
OffchainLabs · Dec 26, 2024 · 83dca75 · 83dca75
1 parent 85ff14c
commit 83dca75
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 8 deletions.
diff --git a/charts/nitro/Chart.yaml b/charts/nitro/Chart.yaml
@@ -7,6 +7,6 @@ maintainers:
 
 type: application
 
-version: 0.6.21
+version: 0.6.22
 
 appVersion: "v3.2.1-d81324d"
diff --git a/charts/nitro/README.md b/charts/nitro/README.md
@@ -114,12 +114,13 @@ helm install xai offchainlabs/nitro -f values.yaml
 | `serviceMonitor.relabelings`                               | Add relabelings for the metrics being scraped                                   | `[]`                                                                |
 | `perReplicaService.enabled`                                | Enable a service for each sts replica                                           | `false`                                                             |
 | `perReplicaService.publishNotReadyAddresses`               | Publish not ready addresses                                                     | `true`                                                              |
-| `perReplicaService.annotations`                            | Annotations for the service                                                     | `{}`                                                                |
+| `perReplicaService.annotations`                            | Annotations for the per replica service                                         | `{}`                                                                |
 | `perReplicaHeadlessService.enabled`                        | Enable a headless service for each sts replica                                  | `false`                                                             |
 | `perReplicaHeadlessService.publishNotReadyAddresses`       | Publish not ready addresses                                                     | `true`                                                              |
-| `perReplicaHeadlessService.annotations`                    | Annotations for the headless service                                            | `{}`                                                                |
+| `perReplicaHeadlessService.annotations`                    | Annotations for the per replica headless service                                | `{}`                                                                |
 | `headlessservice.enabled`                                  | Enable headless service                                                         | `true`                                                              |
 | `headlessservice.publishNotReadyAddresses`                 | Publish not ready addresses                                                     | `true`                                                              |
+| `headlessservice.annotations`                              | Annotations for the headless service                                            | `{}`                                                                |
 | `jwtSecret.enabled`                                        | Enable a jwt secret for use with the stateless validator                        | `false`                                                             |
 | `jwtSecret.value`                                          | Value of the jwt secret for use with the stateless validator                    | `""`                                                                |
 | `auth.enabled`                                             | Enable auth for the stateless validator                                         | `false`                                                             |

diff --git a/charts/nitro/templates/headlessservice.yaml b/charts/nitro/templates/headlessservice.yaml
@@ -5,6 +5,10 @@ metadata:
   name: {{ include "nitro.fullname" . }}-headless
   labels:
     {{- include "nitro.labels" . | nindent 4 }}
+  annotations:
+    {{- if $.Values.headlessservice.annotations }}
+    {{- toYaml $.Values.headlessservice.annotations | nindent 4 }}
+    {{- end }}
 spec:
   type: ClusterIP
   clusterIP: None

diff --git a/charts/nitro/templates/statefulset.yaml b/charts/nitro/templates/statefulset.yaml
@@ -7,15 +7,15 @@ metadata:
   annotations:
     nitro.arbitrum.io/desiredReplicas: {{ $.Values.replicaCount | quote }}
 spec:
-  serviceName: "{{ include "nitro.fullname" . }}"
+  serviceName: {{ include "nitro.fullname" . }}-headless
   replicas: {{ .Values.replicaCount }}
   selector:
     matchLabels:
       {{- include "nitro.selectorLabels" . | nindent 6 }}
   podManagementPolicy: Parallel
   {{- if .Values.updateStrategy }}
   {{- with .Values.updateStrategy }}
-  updateStrategy: 
+  updateStrategy:
     {{- toYaml . | nindent 4 }}
   {{- end }}
   {{- end }}
@@ -276,7 +276,7 @@ spec:
           app: {{ template "nitro.name" . }}
           release: {{ .Release.Name }}
           heritage: {{ .Release.Service }}
-      spec: 
+      spec:
         accessModes:
         {{- toYaml .Values.blobPersistence.accessModes | nindent 8 }}
         {{- if .Values.blobPersistence.storageClassName }}

diff --git a/charts/nitro/values.yaml b/charts/nitro/values.yaml
@@ -105,25 +105,27 @@ serviceMonitor:
 
 ## @param perReplicaService.enabled Enable a service for each sts replica
 ## @param perReplicaService.publishNotReadyAddresses Publish not ready addresses
-## @param perReplicaService.annotations Annotations for the service
+## @param perReplicaService.annotations Annotations for the per replica service
 perReplicaService:
   enabled: false
   publishNotReadyAddresses: true
   annotations: {}
 
 ## @param perReplicaHeadlessService.enabled Enable a headless service for each sts replica
 ## @param perReplicaHeadlessService.publishNotReadyAddresses Publish not ready addresses
-## @param perReplicaHeadlessService.annotations Annotations for the headless service
+## @param perReplicaHeadlessService.annotations Annotations for the per replica headless service
 perReplicaHeadlessService:
   enabled: false
   publishNotReadyAddresses: true
   annotations: {}
 
 ## @param headlessservice.enabled Enable headless service
 ## @param headlessservice.publishNotReadyAddresses Publish not ready addresses
+## @param headlessservice.annotations Annotations for the headless service
 headlessservice:
   enabled: true
   publishNotReadyAddresses: true
+  annotations: {}
 
 ## @param jwtSecret.enabled Enable a jwt secret for use with the stateless validator
 ## @param jwtSecret.value Value of the jwt secret for use with the stateless validator