module installation DB fix

Oksydan · Nov 21, 2022 · de7f5d0 · de7f5d0
1 parent e773a07
commit de7f5d0
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 4 deletions.
diff --git a/is_imageslider.php b/is_imageslider.php
@@ -46,9 +46,9 @@ public function __construct()
     public function install(): bool
     {
         return
-            $this->registerHook('displayHeader')
+            parent::install()
+            && $this->registerHook('displayHeader')
             && $this->registerHook('displayHome')
-            && parent::install()
             && $this->getInstaller()->createTables();
     }
 
@@ -86,7 +86,23 @@ public function getService($serviceName)
      */
     private function getInstaller(): ImageSliderInstaller
     {
-        return $this->get('oksydan.is_imageslider.image_slider_installer');
+        try {
+            $installer = $this->getService('oksydan.is_imageslider.image_slider_installer');
+        } catch (Error $error){
+            $installer = null;
+        }
+
+        if (null === $installer) {
+            $installer = new Oksydan\IsImageslider\Installer\ImageSliderInstaller(
+                $this->getService('doctrine.dbal.default_connection'),
+                (new Oksydan\IsImageslider\Installer\DatabaseYamlParser(
+                    (new Oksydan\IsImageslider\Installer\Provider\DatabaseYamlProvider($this)
+                ))),
+                $this->context
+            );
+        }
+
+        return $installer;
     }
 
     /** @param string $methodName */

diff --git a/src/Installer/ImageSliderInstaller.php b/src/Installer/ImageSliderInstaller.php
@@ -7,6 +7,7 @@
 use Context;
 use Doctrine\DBAL\Connection;
 use PrestaShop\PrestaShop\Adapter\ContainerFinder;
+use Oksydan\IsImageslider\Installer\ActionDatabaseCrateTable;
 
 class ImageSliderInstaller
 {
@@ -52,7 +53,13 @@ public function createTables(): bool
     {
         $databaseData = $this->databaseYaml->getParsedFileData();
         $container = $this->getContainer();
-        $createTableAction = $container->get('oksydan.is_imageslider.installer.action_databse_create_table');
+
+        // THIS WAY INSTEAD OF SERVICE CALL COZ OF NOT AVAILABLE SERVICE DURING INSTALLATION
+        $createTableAction = new ActionDatabaseCrateTable(
+            $container->get('doctrine.dbal.default_connection'),
+            $container->getParameter('database_prefix')
+        );
+
         $createTableAction
             ->setData($databaseData)
             ->buildQuery();