-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert custom code override for maven publishing #33
Conversation
|
thank you @ms-jpq! |
thank you @ms-jpq ! |
Hi @ms-jpq, I just changed the user tokens for the Java SDK, and now the publish workflow is working again. Thank you! |
Hi @ms-jpq It seems that Kotlin SDK release workflow not working again Correctly, it says this error: Task 'publishAndReleaseToMavenCentral' not found in root project 'onebusaway-sdk-kotlin-root' and its subprojects. https://github.com/OneBusAway/kotlin-sdk/actions/runs/11601821428/job/32305429895 |
My apologies, I will take a look |
Hi @ms-jpq, I hope you're doing well. I just wanted to follow up on the issue with the Kotlin SDK release workflow not working. Specifically, the error: Task 'publishAndReleaseToMavenCentral' not found in root project 'onebusaway-sdk-kotlin-root' and its subprojects. I was wondering if there has been any progress or update on this issue. Please let me know if you need any additional details from my side. |
I am extremely sorry for dropping the ball here, I had been overwhelmed with work recently. I will look into this tonight and give a diagnosis on the root cause and follow up with a fix ASAP. |
Thank you for your time and for looking into this. I really appreciate it! |
I think I tracked down the test error down to an internal PR that changed the query param and header params handling. I will need to verify it next Monday with my co-worker though, since this is a thanks giving weekend for us. Will keep you posted edit: this PR should fix it. |
It seems like v0.1.0-alpha.30...v0.1.0-alpha.31 did not include my PR. My PR should go in with the next release from the stainless bot though. Please give me a ping if any issues still remain. Our Java codegen is being heavily worked on ATM :) |
I merged the changes here and the tests work fine now! |
Hola 👋,
I am an eng working at stainless-sdks. I have noticed that your kotlin-sdk's Maven publishing workflow has been failing.
It turns out that due to this custom code commit that changed the file indentation levels, the custom code system have been overriding the lines touched.
So when when you toggled over from the legacy Sonatype OSSRH release flow to their newer Sonatype Central release flow, the changes actually never materialized in the
next
andmain
branches.This pull request rectifies that situation by porting over the ci manifest changes required to successfully release to the Sonatype Central.
The change set is identical to the difference between
generated
andmain
onpublish-sonatype.yml
.Coincidentally, since ~ 3 days ago ( v0.1.0-alpha.7 ), the JavaSDK has been experiencing a token error.
I do not believe that this is related to this particular custom code issue, since v0.1.0-alpha.6 was able to be published without code changes to the publishing flows.
Since I do not have access to your Sonatype account, you might have to look into that 👍 , I suspect that a token rotation via https://central.sonatype.com/ should suffice.