Feat: Svelte 5 Migration #152
Conversation
… using props for click handling
…der, and children
…andleAccordionSelectionChanged function
…erties and simplify SearchField event binding
…and migrate to use $state instead of $set
There was a problem hiding this comment.
looks great! Everything looks like it's working perfectly, and you've fixed #150, too!
I see one comment from the migration task that needs to be addressed—either by deleting the comment or doing whatever work it wasn't able to do, and then we can merge.
src/components/MapContainer.svelte
Outdated
| @@ -1,50 +1,31 @@ | |||
| <!-- @migration-task Error while migrating Svelte code: $$props is used together with named props in a way that cannot be automatically migrated. --> | |||
There was a problem hiding this comment.
looks like there's some more work to do here.
There was a problem hiding this comment.
No, I forgot to remove the comment. It appeared because the migration script failed to remove $$props automatically and it should be done manually, but it has been migrated now to Svelte 5, so there are no errors.
Haha, I’m glad it got fixed with the migration! I didn’t specifically fix #150, but it’s great to see that everything worked out. 😄 @aaronbrethorst |
Fixes: #140, #150
Key Changes:
$stateto define reactive variables instead oflet.$:with$derivedor$effect(Runes support)$propsinstead ofexport letfor component properties.on:clicktoonclickfor consistency, along with similar event changes.slotswithsnippets.routeClickwith aflyTotransaction for smoother navigation.For more details, refer to the Svelte v5 Migration Guide.