Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust i18n docs format #4185

Open
wants to merge 8 commits into
base: x
Choose a base branch
from

Conversation

Lsnsh
Copy link

@Lsnsh Lsnsh commented Mar 7, 2024

#4168

Use correct base branch(x) and change PR branch name.


Adjust i18n related docs format, eg:

Before change:

https://github.com/OneKeyHQ/app-monorepo/blob/064fca17f01c76b26a1a6813a42cd6a7c9adc972/docs/i18n/README.zh-cn.md

image

After change:

https://github.com/OneKeyHQ/app-monorepo/blob/1ba3241b7d039da5dd09470633ffd6af2f2b0168/docs/i18n/README.zh-cn.md

image

Summary by CodeRabbit

  • 文档更新
    • 改善了多语言环境设置文档的清晰度和结构。
    • 更新了安装和配置指令,强调使用 yarn 命令管理依赖。
    • 扩展了常见问题解答部分,提供了更详细的故障排除指导。

Copy link

codesandbox bot commented Mar 7, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

what-the-diff bot commented Mar 7, 2024

PR Summary

  • Update of Installation Instructions
    The instructions for setting up Javascript dependencies and submodules have been added to the README files for German, French, Italian, Japanese, and Chinese versions. This update ensures non-English users can correctly setup the project environment.

@Lsnsh Lsnsh force-pushed the fix/adjust-i18n-docs-format branch from 10bc2a9 to 1d0c7fa Compare March 8, 2024 08:43
@sidmorizon sidmorizon marked this pull request as draft March 21, 2024 01:20
@huhuanming huhuanming marked this pull request as ready for review November 7, 2024 03:26
Copy link
Contributor

coderabbitai bot commented Nov 7, 2024

Walkthrough

本次更改涉及多个语言的i18n文档,主要集中在环境配置和开发指令的清晰度和结构上。各语言的README文件都进行了格式调整,移除了代码块标记,使安装命令更易读。此外,Android项目配置部分被重新组织,明确了社区和官方开发者的不同方法。文档的目录结构和依赖管理说明也得到了改善,FAQ部分扩展了常见问题的解决方案。

Changes

文件路径 更改摘要
docs/i18n/README.de.md 重新格式化环境配置,更新JavaScript依赖安装命令,清晰化Android项目配置,优化目录结构和FAQ部分。
docs/i18n/README.fr.md 格式调整,移除代码块标记,优化Android项目配置说明,保持FAQ部分完整。
docs/i18n/README.it.md 修改安装指令格式,清晰化Android开发者配置,扩展依赖管理说明和FAQ部分。
docs/i18n/README.jp.md 更新开发模式指令,重组Android项目配置,优化仓库结构说明,扩展FAQ部分以解决常见问题。
docs/i18n/README.zh-cn.md 更新JavaScript依赖安装说明,详细说明依赖管理,优化环境配置和常见问题部分。

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Environment
    participant Repository
    participant Dependencies

    Developer->>Environment: 配置环境
    Developer->>Repository: 拉取最新代码
    Repository->>Dependencies: 安装JavaScript依赖
    Dependencies-->>Developer: 依赖安装完成
    Developer->>Environment: 启动开发模式
    Environment-->>Developer: 开发环境准备就绪
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@huhuanming huhuanming enabled auto-merge (squash) November 7, 2024 03:26
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🧹 Outside diff range comments (7)
docs/i18n/README.zh-cn.md (1)

Line range hint 1-24: 建议为所有代码块指定语言

为了提高文档的可读性和代码高亮效果,建议为所有命令行代码块添加 bash 或相应的语言标识。

例如,在文档中的其他命令行代码块也应该指定语言:

-yarn workspace @onekeyhq/web add axios
+```bash
+yarn workspace @onekeyhq/web add axios
+```
🧰 Tools
🪛 Markdownlint

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

docs/i18n/README.jp.md (4)

Line range hint 31-37: 建议补充配置说明的重要性

为了帮助开发者更好地理解,建议添加以下内容:

  • 说明为什么需要这些配置
  • 缺少配置可能带来的影响
  • 如何验证配置是否正确
🧰 Tools
🪛 Markdownlint

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


Line range hint 47-53: 建议完善目录结构说明

为提高文档的实用性,建议:

  • 为每个目录添加具体的使用示例
  • 说明各个包之间的依赖关系
  • 补充每个目录下重要文件的用途
🧰 Tools
🪛 Markdownlint

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


Line range hint 55-61: 建议补充依赖安装的常见问题

为了减少开发者遇到的困扰,建议添加:

  • 常见错误及解决方案
  • 不同操作系统的特殊注意事项
  • 版本兼容性说明
🧰 Tools
🪛 Markdownlint

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


Line range hint 63-72: 建议扩充FAQ内容

为了提供更全面的帮助,建议增加以下常见问题:

  • 开发环境配置问题
  • 编译打包相关问题
  • 调试技巧
  • 性能优化建议
🧰 Tools
🪛 Markdownlint

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

docs/i18n/README.it.md (2)

Line range hint 35-42: 建议完善 Android 配置说明

社区开发者配置部分需要补充以下信息:

  1. keys.c 文件的具体结构
  2. 默认选项的使用限制说明
  3. 可能遇到的 API 限制具体有哪些
🧰 Tools
🪛 Markdownlint

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


Line range hint 82-86: 建议扩展环境问题排查步骤

为了帮助开发者更好地解决环境问题,建议:

  1. 详细列出 yarn clean 会清理哪些内容
  2. 添加清理后的验证步骤
  3. 补充常见错误的具体表现和解决方案

需要我帮您编写详细的故障排除指南吗?

🧰 Tools
🪛 Markdownlint

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between 1e302a4 and 6bc9ebc.

📒 Files selected for processing (5)
  • docs/i18n/README.de.md (1 hunks)
  • docs/i18n/README.fr.md (1 hunks)
  • docs/i18n/README.it.md (1 hunks)
  • docs/i18n/README.jp.md (1 hunks)
  • docs/i18n/README.zh-cn.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
docs/i18n/README.de.md

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

docs/i18n/README.fr.md

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

docs/i18n/README.it.md

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

docs/i18n/README.jp.md

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

docs/i18n/README.zh-cn.md

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🔇 Additional comments (2)
docs/i18n/README.de.md (1)

Line range hint 1-24: 文档结构清晰,内容完整

文档组织合理,包含了环境配置、开发指令和项目结构等重要信息,对开发者很有帮助。安装步骤和故障排除指南也很详细。

🧰 Tools
🪛 Markdownlint

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

docs/i18n/README.fr.md (1)

Line range hint 1-24: 文档结构清晰,内容完整

文档组织合理,包含了环境配置、开发指南、目录结构和常见问题等重要部分。安装步骤和工作区设置说明清晰明了,对开发者很友好。

🧰 Tools
🪛 LanguageTool

[typographical] ~10-~10: Caractère d’apostrophe incorrect.
Context: ...s le répertoire racine avec la commande yarn. Installer toutes les dépendance...

(APOS_INCORRECT)

🪛 Markdownlint

14-14: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

docs/i18n/README.zh-cn.md Show resolved Hide resolved
docs/i18n/README.jp.md Show resolved Hide resolved
docs/i18n/README.de.md Show resolved Hide resolved
docs/i18n/README.it.md Show resolved Hide resolved
docs/i18n/README.fr.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants