Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove random querystrings from extension build artifacts #5404

Open
wants to merge 5 commits into
base: x
Choose a base branch
from
Open

refactor: remove random querystrings from extension build artifacts #5404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3525043
refactor: use currentVersion instead of Date.now
goosewobbler Aug 2, 2024
3f36e9a
chore: ensure webpack compilation hash is restricted to dev
goosewobbler Aug 2, 2024
2fdf3e1
Merge branch 'x' into sm/ext-reproducible-builds
goosewobbler Aug 2, 2024
9e5bff9
Merge branch 'x' into sm/ext-reproducible-builds
huhuanming Aug 6, 2024
9cdd492
Merge branch 'x' into sm/ext-reproducible-builds
goosewobbler Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions development/indexHtmlParameter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ function createEjsParams({ filename = '', platform = '', browser = '' }) {
platform,
browser,
htmlHeadPreloadCode,
currentVersion: process.env.VERSION,
isDev: process.env.NODE_ENV === 'development',
};
}
Expand Down
2 changes: 1 addition & 1 deletion development/webpack/ext/pluginsHtml.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function createHtmlPlugin({ name, chunks }) {
// chunks: [name],
chunks: chunks || [name],
cache: false,
hash: true,
hash: process.env.NODE_ENV === 'development',
});
const interpolateHtmlPlugin = new InterpolateHtmlPlugin(
HtmlWebpackPlugin,
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/web/index.html.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<!-- <script>-->
<!-- // ** inline script not allowed in Ext, use themePreload.js instead-->
<!-- </script>-->
<script src="/preload-html-head.js?<%=Date.now() %>"></script>
<script src="/preload-html-head.js?<%= currentVersion %>"></script>
<% } %>

<% if ( platform === 'desktop' || platform === 'web' ) { %>
Expand Down