usage of javascript/node to allow cross-platform building #5825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Osiris-Team
requested review from
ezailWang,
loatheb,
sidmorizon,
originalix and
huhuanming
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
PR总结
|
|
Thanks for your contribution @Osiris-Team But we're not planning to introduce Python scripts into the project, you can consider converting the Python scripts to Node scripts. |
|
Oh yeah that makes sense, didn't think about that! |
|
Thanks for your contribution @Osiris-Team. but development/scripts/copy_injected.js is still a python file. Maybe you can make modifications based on this draft PR #5830 |
|
my bad forgot to copy over, fixed |
huhuanming
reviewed
Sep 14, 2024
| @@ -11,9 +11,10 @@ | |||
| "node": ">=20" | |||
| }, | |||
| "scripts": { | |||
| "setup:env": "bash -c 'if [ ! -f .env ]; then cp .env.example .env; fi'", | |||
There was a problem hiding this comment.
Would it be better to write it like this?
"setup:env": "node -e \"const fs=require('fs');if(!fs.existsSync('.env'))fs.copyFileSync('.env.example','.env');\"",
|
and apps/desktop/dist/build_keytar.sh need to be fixed. After all the files have been modified, I will help you package and test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the current state the build fails when following the simple instructions in the README on Windows.
This fixes it.