-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace classic mini homescreen image #5854
base: x
Are you sure you want to change the base?
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -789,11 +789,34 @@ class ServiceHardware extends ServiceBase { | |||
await CoreSDKLoader(); | |||
const device = await localDb.getDevice(checkIsDefined(dbDeviceId)); | |||
let names = getHomeScreenDefaultList(device.featuresInfo || ({} as any)); | |||
if (['classic', 'mini', 'classic1s'].includes(device.deviceType)) { | |||
const isT1Model = ['classic', 'mini', 'classic1s'].includes( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utils 方法判断
@@ -803,6 +826,12 @@ class ServiceHardware extends ServiceBase { | |||
homeScreenType, | |||
thumbnail: true, | |||
}); | |||
if (!size && isT1Model) { | |||
size = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utils 方法判断
// eslint-disable-next-line no-param-reassign | ||
imgHex = imgHex || getHomeScreenHex(deviceType, imgName); | ||
imgHex = imgHex || internalHex; | ||
if (imgName === 'blank') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imgName 类型约束
a0a4bee
to
d1aac36
Compare
d1aac36
to
e051512
Compare
No description provided.