Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page sdk init to handle delayed setting of window.OneSignalDeferred #1240

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

fadi-george
Copy link
Contributor

@fadi-george fadi-george commented Mar 21, 2025

Description

1 Line Summary

Details

If window.OneSignalDeferred is not set in time before processOneSignalDeferredArray is called, it will lead to an is not iterable error.

  • So added a nullish coalescing check before the process call
  • Removed OneSignalDeferred class and just update the push property of window.OneSignalDeferred for better typings / simplicity
  • Improved global typings for OneSignal and OneSignalDeferred

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets



This change is Reviewable

@fadi-george fadi-george force-pushed the fg/process-deffered branch 5 times, most recently from ef65735 to c7641be Compare March 24, 2025 18:35
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, only noticed one extra console.log that should be cleaned up.

@fadi-george fadi-george force-pushed the fg/process-deffered branch from c7641be to d464342 Compare March 25, 2025 17:01
@fadi-george fadi-george merged commit 00d264a into main Mar 25, 2025
4 checks passed
@fadi-george fadi-george deleted the fg/process-deffered branch March 25, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants