Reimplement KaleidoScope_DrawItemSelect, Restore Equip Swap

[flagrama]

This needs testing and some more cleanup, but this replaces the ASM hacks for free movement on the item pause screen by reimplementing KaleidoScope_DrawItemSelect in C. This gives more flexibility in changing behaviours in this menu.

As well as reimplementing the function, the glitch known as Equip Swap has been restored by limiting the exact range of freedom originally given to the Vertical movement in the menu. You can no longer select empty slots on the far left or far right by pressing up or down. The behaviour if there are items above or below with empty spaces should be unchanged though. This makes menuing slightly more awkward, but not massively. It also still prevents any potential softlocks from item placement since the central area is completely free to move around in, and the Horizontal axis has no limits at all.

Some additional hacks had to be reimplemented, but they were pretty simple to add in to the C code. Code to prevent you from equipping an empty slot has been reimplemented, and the clever hack to prevent the "equip to c buttons" textures from appearing on empty slots was reimplemented as well.

I tried to leave plenty of documentation in the code, at least as to how far I understand it after hacking away on it, as well as mentioning all of the hacks that randomizer required that a plain reimplementation would not have needed.

[AngheloAlf]

I think it could be a good idea to add a plando test file with a seed that starts with the problematic cases for equip swap, so it is easier for people to test this locally

[AngheloAlf]

Since there are plans on adding a linker script to manually specify sections I suggest this linker script to be named something like oot_symbols.ld, original_symbols.ld, rom_symbols.ld, undefined_syms.ld, etc

(linkers allow passing multiple linker scripts on the invocation.)

[AngheloAlf]

I also suggest adding a note like "This symbol list is ordered by the address", to remind future contributors to keep the list ordered

[flagrama]

What about including an entire folder of *.ld files. I kind of would like to have the sfx stuff in an audio file, the dl42 setup and texture/icons in a graphics file, and the rest in a kaleido file. It might seem like overkill at this point, but looking at z64.h this file is bound to get out of hand quickly even if it is just existing symbols. (this question isn't exactly directed at you, should be easy enough to include multiple linker files in the makefile)

[AngheloAlf]

Having specialized linker script files sounds like a good idea to me. Just take in mind that you will need to pass the -T flag for each one of them (-T file1.ld -T file2.ld -T file3.ld)

[flagrama]

I think it could be a good idea to add a plando test file with a seed that starts with the problematic cases for equip swap, so it is easier for people to test this locally

I already shared patches with a known currently problematic setup in the discord dev channel to have some people test them and have tested them myself now. At this point if someone wanted to test something they'd know better than me what needs tested.

[AngheloAlf]

Thinking again about this. I'm not that sure having multiple linker scripts for defining symbols is that good. Sounds annoying to maintain for the rando people in the long run

[flagrama]

Does anyone else have opinions on this?

[mzxrules]

I probably prefer the single file as well