Preset CLI Aliases #2175
Merged
Preset CLI Aliases #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds aliases to each preset that can be used instead of the full display name when specifying a setting preset in the CLI using `--setting_preset`
Cuphat
added
Type: Enhancement
fenhl
requested changes
Feb 11, 2024
There was a problem hiding this comment.
We should ensure all the existing RandoBot aliases defined at https://ootrandomizer.com/rtgg/ootr_presets_dev.json are present. Looks good other than that.
As suggested by fenhl.
fenhl
approved these changes
Feb 11, 2024
fenhl
added
the
Status: Waiting for Release
fenhl
removed
the
Status: Waiting for Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds aliases to each preset that can be used instead of the full display name when specifying a setting preset in the CLI using
--setting_presetI did this rather quick so feel free to look over it and make sure I am not doing something dumb.