Improve VC startup screen with a loading percentage and less confusing text #2382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the great work by Rebbacus, the VC crash patch is scheduled to go live on the OoTRandomizer.com website in the coming days. Since this will push the patch to multiple thousand highly casual users, I wanted to address some minor concerns I had with the current startup screen, since I think it might confuse people in its current state.
So this PR does the following:
Display the progress in percentage instead of MB which is more easily understood. It currently assumes a fixed ROM size of 32 MB, which can be too low if the randomizer exceeds that amount. For that reason the percentage is capped at 100%. This should be negligible as loading is fast enough to not hover on 100% for too long even if the ROM is bigger than 32 MB
Alter the status text to not contain information that the rando uses in other places. I think including a timestamp or potentially a full semver version here is suboptimal as the user might think this is the timestamp or rando version of his WAD, which could lead to the assumption that you are still having an old WAD installed in your Wii cache. To address this I went with a simple Revision style version marker, since I don't assume this patch will change much in the future. So this keeps it simple while still allowing identification of the patch version used for debugging purposes
Here is how the startup screen looks now:

Both region patches were tested by me and look fine.