Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VC startup screen with a loading percentage and less confusing text #2382

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

dragonbane0
Copy link
Collaborator

@dragonbane0 dragonbane0 commented Feb 25, 2025

Following the great work by Rebbacus, the VC crash patch is scheduled to go live on the OoTRandomizer.com website in the coming days. Since this will push the patch to multiple thousand highly casual users, I wanted to address some minor concerns I had with the current startup screen, since I think it might confuse people in its current state.

So this PR does the following:

  1. Display the progress in percentage instead of MB which is more easily understood. It currently assumes a fixed ROM size of 32 MB, which can be too low if the randomizer exceeds that amount. For that reason the percentage is capped at 100%. This should be negligible as loading is fast enough to not hover on 100% for too long even if the ROM is bigger than 32 MB

  2. Alter the status text to not contain information that the rando uses in other places. I think including a timestamp or potentially a full semver version here is suboptimal as the user might think this is the timestamp or rando version of his WAD, which could lead to the assumption that you are still having an old WAD installed in your Wii cache. To address this I went with a simple Revision style version marker, since I don't assume this patch will change much in the future. So this keeps it simple while still allowing identification of the patch version used for debugging purposes

Here is how the startup screen looks now:
startup screen

Both region patches were tested by me and look fine.

@dragonbane0 dragonbane0 added Type: Enhancement New feature or request Component: ASM/C Changes some internals of the ASM/C libraries labels Feb 25, 2025
@fenhl fenhl added this to the next milestone Feb 25, 2025
@fenhl fenhl merged commit a08343e into OoTRandomizer:Dev Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants