Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more nullptr checks #78

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add more nullptr checks #78

wants to merge 1 commit into from

Conversation

martonmiklos
Copy link
Contributor

Triggered when the implement timed out while the input dialog was open.

GwnDaan
GwnDaan approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@GwnDaan GwnDaan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I think we should also add a nullptr check either around process_macro or inside execute_macro (that function gets called by process_macro):

https://github.com/Open-Agriculture/AgIsoStack-plus-plus/blob/main/isobus%2Fsrc%2Fisobus_virtual_terminal_server.cpp#L158

There it can also lead to a crash if there is macro referenced by the object for which the input was open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GwnDaan GwnDaan GwnDaan approved these changes

@ad3154 ad3154 ad3154 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martonmiklos @ad3154 @GwnDaan