Chore/rollup experiment #152
Conversation
rollup.config.js
Outdated
| // console.log(filepaths); | ||
|
|
||
| // exclude all dependencies from being bundled together, except for the problematic jsonLd, used by "open-attestation", "oa-verify" dependencies | ||
| let deps = [...Object.keys(pkge.dependencies), ...Object.keys(pkge.devDependencies)] |
There was a problem hiding this comment.
devdependencies shouldnt be bundled so let's not exclude
There was a problem hiding this comment.
3rd-party dependencies, i.e. node modules, shouldn't be bundled together. This is so regardless of whether they are direct dependencies or dev-dependencies.
Here i am trying to prevent the rollup from bundling all the node modules (except for the open-attestation libs as we want the problematic import and export lines in the esm files to be removed). In the lines below, the deps variable is specified in the external config property to exclude them
There was a problem hiding this comment.
Also we should actually bundle everything as it's not a library but an app, but I'm fine with the current approach
There was a problem hiding this comment.
remove pkge.devDependencies
rollup experiment