Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change def and label of duration/time span #1004 #1017

Merged
merged 4 commits into from
Feb 9, 2022
Merged

change def and label of duration/time span #1004 #1017

merged 4 commits into from
Feb 9, 2022

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented Feb 8, 2022

closes #1004

@github-actions github-actions bot added oeo-model changes the oeo-model module oeo-shared changes the oeo-shared module labels Feb 8, 2022
@stap-m stap-m requested review from l-emele and KaiSchnepf February 8, 2022 13:02
l-emele
l-emele approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comment on the quotation marks everything looks fine, so I approve this PR.

@stap-m stap-m merged commit c732274 into dev Feb 9, 2022
@stap-m stap-m deleted the feature-1004-duration branch February 9, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-emele l-emele l-emele approved these changes

@KaiSchnepf KaiSchnepf Awaiting requested review from KaiSchnepf

Assignees
No one assigned
Labels
oeo-model changes the oeo-model module oeo-shared changes the oeo-shared module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'alternative term' for duration
2 participants
@stap-m @l-emele