-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make var assignment safer #4
base: main
Are you sure you want to change the base?
Conversation
/cc @jorgebucaran any comment here? |
Well, by using -g, you've declared the variable globally. Now, I'm unclear about your intentions here. Why are you forking all these projects instead of creating issues or pull requests? Frankly, I see no justification for this repository to exist. I don't think you even need autoenv to begin with. Simply set the environment or create a new shell to reset it. |
ok, i would assume that's not desirable? The AI maybe lied to us.. |
well, in the case of Fisher plugins, we need to fork everything bc the repo maintainer can do any breaking change on a whim and we are like at their mercy w/o any warning
it is useful! check out OpenINF/openinf.github.io#1179 |
Fair enough, you must know what you're doing! Anyway, yes, adding On another note, I've decided to remove myself from the funding file. I don't feel that I'm contributing enough to warrant being listed there. Do feel free to ping me if you need any help with Fish or Fisher. 👍 |
i must admit, it does look awkward to be listed there as we make forks like this (i will remove myself as well)
btw, on the JS front, we have simply been waiting for the @babel release that adds support for decorators and that happened a couple weeks ago, so you will be seeing some JS w/ decorators coming from us soon :) |
Refs: OpenINF/openinf-autoenvstack#4 (comment) Signed-off-by: Derek Lewis <[email protected]>
alright, i have recently found a way to do this automatically and Princess Irulen correctly points out that one cannot really turn it off (yet), so we are going to remove it [until it is ready for prime time], actually |
In Fish: exec fish creates a new shell session, resetting all variables in the process without manually opening a new tab. This can be useful for programmatically managing the environment. Now, this approach can sometimes lead to complications, so be careful. 😄 If you write down the exact functionalities you're looking for, without relying on autoenvstack or vendor tools, I can attempt to create a custom plugin from scratch that meets said specification, provided the requirements aren't overly complex. |
Pull Request Purpose
Make a selection on the purpose(s) of your changes.
This PR contains the following:
Testing
Have you included any tests in your submission?
tests)
Breaking Changes
Have you modified any aspect public API surface (i.e., caused breakage)?
necessary)
Description
A concise recap summarily detailing what all are the changes being made.
List of any relevant issue numbers: