Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make var assignment safer #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DerekNonGeneric
Copy link
Member

Pull Request Purpose

Make a selection on the purpose(s) of your changes.

This PR contains the following:

  • 🐞🔧 bugfixing (🐜/🦟/🐛/🦗/🐝 et al.)
  • 🆕🎏 implementation of new feature(s)
  • ♻️ refactoring(s)
  • 📄 documentation modification(s)
  • 🔮 other

Testing

Have you included any tests in your submission?

  • yes (bugfixes and features will not be merged without
    tests
    )
  • no

Breaking Changes

Have you modified any aspect public API surface (i.e., caused breakage)?

  • yes (breaking changes will not be merged unless
    necessary
    )
  • no

Description

A concise recap summarily detailing what all are the changes being made.

List of any relevant issue numbers:

@DerekNonGeneric
Copy link
Member Author

/cc @jorgebucaran

any comment here?

@jorgebucaran
Copy link

Well, by using -g, you've declared the variable globally. Now, I'm unclear about your intentions here. Why are you forking all these projects instead of creating issues or pull requests? Frankly, I see no justification for this repository to exist. I don't think you even need autoenv to begin with. Simply set the environment or create a new shell to reset it.

@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Mar 16, 2024

Well, by using -g, you've declared the variable globally.

ok, i would assume that's not desirable? The AI maybe lied to us..

@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Mar 16, 2024

Now, I'm unclear about your intentions here. Why are you forking all these projects instead of creating issues or pull requests?

well, in the case of Fisher plugins, we need to fork everything bc the repo maintainer can do any breaking change on a whim and we are like at their mercy w/o any warning

Frankly, I see no justification for this repository to exist. I don't think you even need autoenv to begin with. Simply set the environment or create a new shell to reset it.

it is useful! check out OpenINF/openinf.github.io#1179

@jorgebucaran
Copy link

Fair enough, you must know what you're doing! Anyway, yes, adding -g declares the variable globally, that's all. I'm not sure what the aim is here, but I just wanted to point that out.

On another note, I've decided to remove myself from the funding file. I don't feel that I'm contributing enough to warrant being listed there. Do feel free to ping me if you need any help with Fish or Fisher. 👍

@DerekNonGeneric
Copy link
Member Author

On another note, I've decided to remove myself from the funding file. I don't feel that I'm contributing enough to warrant being listed there.

i must admit, it does look awkward to be listed there as we make forks like this (i will remove myself as well)

Do feel free to ping me if you need any help with Fish or Fisher. 👍

btw, on the JS front, we have simply been waiting for the @babel release that adds support for decorators and that happened a couple weeks ago, so you will be seeing some JS w/ decorators coming from us soon :)

DerekNonGeneric added a commit to OpenINF/.github that referenced this pull request Mar 18, 2024
@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Mar 18, 2024

I don't think you even need autoenv to begin with. Simply set the environment or create a new shell to reset it.

alright, i have recently found a way to do this automatically and Princess Irulen correctly points out that one cannot really turn it off (yet), so we are going to remove it [until it is ready for prime time], actually

@jorgebucaran
Copy link

In Fish:

exec fish

creates a new shell session, resetting all variables in the process without manually opening a new tab. This can be useful for programmatically managing the environment. Now, this approach can sometimes lead to complications, so be careful. 😄

If you write down the exact functionalities you're looking for, without relying on autoenvstack or vendor tools, I can attempt to create a custom plugin from scratch that meets said specification, provided the requirements aren't overly complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants