Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies for Jakarta EE 11 TCK #141

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Update dependencies for Jakarta EE 11 TCK #141

merged 2 commits into from
Oct 15, 2024

Conversation

jhanders34
Copy link
Member

@jhanders34 jhanders34 commented Oct 14, 2024 •
edited
Loading

Short description of what this resolves:

Update versions of arquillian and surefire to support Jakarta EE 11 TCK

Changes proposed in this pull request:

  • Move up to arquillian 1.9.1.Final
  • Move jakarta specific dependencies to 10.0.0.Final version with the new versioning that is done
  • Update surefire dependency to 3.2.5
  • Newer arquillian version support Java 11+ so stop running Java 8 test and add Java 21 testing

Fixes: #140

@jhanders34 jhanders34 requested a review from cherylking October 14, 2024 18:15
@jhanders34 jhanders34 self-assigned this Oct 14, 2024
@jhanders34 jhanders34 linked an issue Oct 14, 2024 that may be closed by this pull request
Update dependencies to support Jakarta EE 11 TCK #140
Closed
@cherylking
Copy link
Member

Looks like the changes don't support Java 8. Do we need a different branch for this support? Or do we declare dropping of Java 8 support when we add this?

@jhanders34
Copy link
Member Author

Looks like the changes don't support Java 8. Do we need a different branch for this support? Or do we declare dropping of Java 8 support when we add this?

Yes it appears so. EE10 supports Java 11 plus so that makes sense. We will need a new version for sure. I assume we will still use main for forward development, but only do point releases for 2.1 going forward in a 2.1 branch. So not sure if you need a 2.2 or a 3.0 release for this change. Let me update the PR to include the updates needed to drop Java 8 support.

@cherylking
Copy link
Member

It seems like we will need a 2.x-maintenance release similar to what we did for 1.x. Then we should bump to 3.0 for a release with Jakarta EE 11 support and remove Java 8 support at the same time.

@jhanders34 jhanders34 force-pushed the jhanders34-branch branch 4 times, most recently from b280bf8 to d3616fb Compare October 15, 2024 13:07
@jhanders34
Update arquillian dependencies for Jakarta EE 11
a5b64fe 
- Move up to arquillian 1.9.1.Final
- Move jakarta specific dependencies to 10.0.0.Final version with the
new versioning that is done.
cherylking
cherylking requested changes Oct 15, 2024
View reviewed changes
cherylking
cherylking approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cherylking cherylking merged commit 8ea8e90 into OpenLiberty:main Oct 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylking cherylking cherylking approved these changes

Assignees

@jhanders34 jhanders34

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update dependencies to support Jakarta EE 11 TCK
2 participants
@jhanders34 @cherylking