Simplify the apt install #304
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripton
approved these changes
Mar 2, 2025
| if [ "$TASK" = "codespell" ]; then sudo apt-get -y install python3-pip git; fi | ||
| if [ "$TASK" = "codespell" ]; then python3 -m pip install --no-input git+https://github.com/codespell-project/codespell.git; fi | ||
| #if [ "$TASK" = "codespell" ]; then pip install codespell; fi | ||
| sudo apt-get install -y xvfb libhtml-parser-perl lintian moreutils |
There was a problem hiding this comment.
Having this in one line makes the diff less readable in the future, should packages removed or added. However, one apt install command per line is also not perfect.
Can we do:
apt install \
xvfb \
... \
... \
...
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.