Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable LTO/IPO for Release configuration #2991

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Conversation

ZehMatt
Copy link
Contributor

@ZehMatt ZehMatt commented Mar 6, 2025

For some saves I tested I got additional extra 30 FPS so that is pretty good, the downside is that Release builds will take a bit longer now. I think it might be an idea to consider building RelWithDebInfo rather than Release for PRs and only do Release on master/releases. But for now I suggest we just see how it goes.

Copy link
Contributor

@duncanspumpkin duncanspumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably address the warnings as well if possible

@duncanspumpkin duncanspumpkin added this to the v25.02+ milestone Mar 7, 2025
@ZehMatt
Copy link
Contributor Author

ZehMatt commented Mar 7, 2025

I haven't even noticed those, do you want it to be done in this PR or another?

@duncanspumpkin
Copy link
Contributor

I haven't even noticed those, do you want it to be done in this PR or another?

whatever is easiest

@ZehMatt
Copy link
Contributor Author

ZehMatt commented Mar 7, 2025

Probably better for another PR, I'll see what's up with that.

@ZehMatt ZehMatt merged commit 51eb939 into OpenLoco:master Mar 7, 2025
10 checks passed
@ZehMatt ZehMatt deleted the lto-build branch March 7, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants