Skip to content

Commit

Permalink
remove(api): profile alias are no gone since not used
Browse files Browse the repository at this point in the history
  • Loading branch information
lindesvard committed Feb 24, 2025
1 parent 5863dd8 commit 86bf9dd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 83 deletions.
37 changes: 6 additions & 31 deletions apps/api/src/controllers/track.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,10 @@ import type { FastifyReply, FastifyRequest } from 'fastify';
import { path, assocPath, pathOr, pick } from 'ramda';

import { generateDeviceId, parseUserAgent } from '@openpanel/common/server';
import {
createProfileAlias,
getProfileById,
getProfileIdCached,
getSalts,
upsertProfile,
} from '@openpanel/db';
import { getProfileById, getSalts, upsertProfile } from '@openpanel/db';
import { eventsQueue } from '@openpanel/queue';
import { getRedisCache } from '@openpanel/redis';
import type {
AliasPayload,
DecrementPayload,
IdentifyPayload,
IncrementPayload,
Expand Down Expand Up @@ -110,12 +103,7 @@ export async function handler(
}

const identity = getIdentity(request.body);
const profileId = identity?.profileId
? await getProfileIdCached({
projectId,
profileId: identity?.profileId,
})
: undefined;
const profileId = identity?.profileId;

// We might get a profileId from the alias table
// If we do, we should use that instead of the one from the payload
Expand Down Expand Up @@ -183,9 +171,10 @@ export async function handler(
break;
}
case 'alias': {
await alias({
payload: request.body.payload,
projectId,
reply.status(400).send({
status: 400,
error: 'Bad Request',
message: 'Alias is not supported',
});
break;
}
Expand Down Expand Up @@ -305,20 +294,6 @@ async function identify({
});
}

async function alias({
payload,
projectId,
}: {
payload: AliasPayload;
projectId: string;
}) {
await createProfileAlias({
alias: payload.alias,
profileId: payload.profileId,
projectId,
});
}

async function increment({
payload,
projectId,
Expand Down
52 changes: 0 additions & 52 deletions packages/db/src/services/profile.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,30 +188,6 @@ export function transformProfile({
};
}

export async function createProfileAlias({
projectId,
alias,
profileId,
}: {
projectId: string;
alias: string;
profileId: string;
}) {
await getProfileIdCached.clear({ profileId, projectId });
await ch.insert({
table: TABLE_NAMES.alias,
format: 'JSONEachRow',
values: [
{
projectId,
profile_id: profileId,
alias,
created_at: new Date(),
},
],
});
}

export async function upsertProfile(
{
id,
Expand Down Expand Up @@ -240,31 +216,3 @@ export async function upsertProfile(
isFromEvent,
);
}

export async function getProfileId({
profileId,
projectId,
}: {
profileId: number | string | undefined;
projectId: string;
}) {
if (!profileId) {
return '';
}

const res = await chQuery<{
alias: string;
profile_id: string;
project_id: string;
}>(
`SELECT * FROM ${TABLE_NAMES.alias} WHERE project_id = '${projectId}' AND (alias = '${profileId}' OR profile_id = '${profileId}')`,
);

if (res[0]) {
return res[0].profile_id;
}

return String(profileId);
}

export const getProfileIdCached = cacheable(getProfileId, 60 * 30);

0 comments on commit 86bf9dd

Please sign in to comment.