feat(app,shared-data): Add basic support for the Flex Stacker module to the front-end. #17295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegano1
changed the title
vegano1
force-pushed
the
flex-stacker-frontend-basic
branch
from
057a705 to
2e98eb4
Compare
vegano1
changed the title
koji
reviewed
Jan 17, 2025
Comment on lines
11
to
13
| export const FlexStackerModuleData = ( | ||
| props: FlexStackerModuleProps | ||
| ): JSX.Element | null => { |
There was a problem hiding this comment.
Suggested change
| export const FlexStackerModuleData = ( | |
| props: FlexStackerModuleProps | |
| ): JSX.Element | null => { | |
| export function FlexStackerModuleData( | |
| props: FlexStackerModuleProps | |
| ): JSX.Element | null { |
koji
reviewed
Jan 17, 2025
koji
reviewed
Jan 17, 2025
| onCloseClick={handleCloseSlideout} | ||
| isExpanded={isExpanded} | ||
| > | ||
| <LegacyStyledText |
There was a problem hiding this comment.
is there any specific reason to use LegacyStyledText instead of StyledText?
There was a problem hiding this comment.
I'd guess this is copy/pasted from older module slide outs. I'll update it
koji
reviewed
Jan 17, 2025
There was a problem hiding this comment.
I'll make a TODO to add tests when we build this out to design specs. This PR is just meant to unblock science & ABR from using the stacker in a protocol!
koji
reviewed
Jan 17, 2025
smb2268
approved these changes
Jan 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17295 +/- ##
==========================================
+ Coverage 73.84% 79.04% +5.20%
==========================================
Files 43 120 +77
Lines 3303 4587 +1284
==========================================
+ Hits 2439 3626 +1187
- Misses 864 961 +97
Flags with carried forward coverage won't be shown. Click here to find out more. |
koji
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds the basic scaffolding for the Flex Stacker so the app won't crash when it encounters one.
Closes: EXEC-1088 EXEC-1089
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment